Skip to content

Conversation

@djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #729

Problem Summary:
Support writing traffic files to S3 so no need to copy files manually.

What is changed and how it works:

  • Import tidb/br/pkg/storage to support external storage
  • Update dependency to resolve package conflicts
  • Replace *os.File with ExternalFileWriter or ExternalFileReader
  • Write both meta and traffic files to ExternalStorage.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox January 7, 2025 06:25
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 7, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.69444% with 35 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@172649a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/store/rotate.go 80.00% 5 Missing and 4 partials ⚠️
pkg/sqlreplay/capture/capture.go 68.00% 6 Missing and 2 partials ⚠️
pkg/sqlreplay/replay/replay.go 71.42% 4 Missing and 2 partials ⚠️
pkg/sqlreplay/store/line.go 28.57% 4 Missing and 1 partial ⚠️
pkg/sqlreplay/store/meta.go 77.77% 2 Missing and 2 partials ⚠️
pkg/sqlreplay/store/storage.go 83.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage        ?   66.17%           
=======================================
  Files           ?      126           
  Lines           ?    11489           
  Branches        ?        0           
=======================================
  Hits            ?     7603           
  Misses          ?     3332           
  Partials        ?      554           
Flag Coverage Δ
unit 66.17% <75.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 7, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 10:31:05.356130359 +0000 UTC m=+263208.644962067: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 7, 2025
@ti-chi-bot ti-chi-bot bot merged commit 01e5a82 into pingcap:main Jan 7, 2025
5 checks passed
@djshow832 djshow832 deleted the s3 branch January 7, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output traffic files to a remote address

3 participants