Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #808

What problem does this PR solve?

Issue Number: close #806

Problem Summary:
When routing and setting config concurrently, the FactorBasedBalance.factors is read and written concurrently, leading a data race.

What is changed and how it works:
Add a lock in the FactorBasedBalance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Fix data race when routing and setting config concurrently.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.3@c22b4db). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.3     #809   +/-   ##
==============================================
  Coverage               ?   66.53%           
==============================================
  Files                  ?      122           
  Lines                  ?    11336           
  Branches               ?        0           
==============================================
  Hits                   ?     7542           
  Misses                 ?     3260           
  Partials               ?      534           
Flag Coverage Δ
unit 66.53% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-03 07:44:19.594998997 +0000 UTC m=+341345.797344261: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit 7ec9ae7 into pingcap:release-1.3 Jun 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants