Skip to content

meter, config: meter public and private response traffic independently (#993)#994

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-nextgen-20251023from
ti-chi-bot:cherry-pick-993-to-release-nextgen-20251023
Nov 27, 2025
Merged

meter, config: meter public and private response traffic independently (#993)#994
ti-chi-bot[bot] merged 3 commits intopingcap:release-nextgen-20251023from
ti-chi-bot:cherry-pick-993-to-release-nextgen-20251023

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #993

What problem does this PR solve?

Issue Number: close #990

Problem Summary:
The costs for public endpoint and private endpoint traffic are different, so meter them independently.

What is changed and how it works:

  • Add a config proxy.public-endpoints to pass in the public NLB IP or CIDR.
  • Move the parsing CIDR and matching CIDR functions into netutil.
  • Update outBound_bytes to private_outBound_bytes and public_outBound_tytes of the metering system.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 27, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Nov 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-27 05:36:05.835208441 +0000 UTC m=+767529.484402898: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 27, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-nextgen-20251023@1f96aff). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/util/netutil/netutil.go 71.87% 6 Missing and 3 partials ⚠️
pkg/proxy/proxy.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##             release-nextgen-20251023     #994   +/-   ##
===========================================================
  Coverage                            ?   67.63%           
===========================================================
  Files                               ?      137           
  Lines                               ?    13505           
  Branches                            ?        0           
===========================================================
  Hits                                ?     9134           
  Misses                              ?     3740           
  Partials                            ?      631           
Flag Coverage Δ
unit 67.63% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit 7bfb50f into pingcap:release-nextgen-20251023 Nov 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants