Skip to content

sqlreplay: fix replay quits immediately after graceful pause#995

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
djshow832:log_finish
Nov 28, 2025
Merged

sqlreplay: fix replay quits immediately after graceful pause#995
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
djshow832:log_finish

Conversation

@djshow832
Copy link
Copy Markdown
Collaborator

@djshow832 djshow832 commented Nov 27, 2025

What problem does this PR solve?

Issue Number: close #996

Problem Summary:
The graceful flag was not reset after start, leading to the replayer stops immediately at the second replay.

What is changed and how it works:

  • Reset the graceful flag before start
  • Add more logs to troubleshoot

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added size/L and removed size/S labels Nov 28, 2025
@djshow832 djshow832 changed the title add logs sqlreplay: fix replay quits immediately after graceful pause Nov 28, 2025
@djshow832 djshow832 marked this pull request as ready for review November 28, 2025 01:04
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@704568c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/replay/replay.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage        ?   67.55%           
=======================================
  Files           ?      140           
  Lines           ?    14179           
  Branches        ?        0           
=======================================
  Hits            ?     9579           
  Misses          ?     3917           
  Partials        ?      683           
Flag Coverage Δ
unit 67.55% <88.88%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the lgtm label Nov 28, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Nov 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-28 03:03:41.681211057 +0000 UTC m=+844785.330405514: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot Bot added the approved label Nov 28, 2025
@ti-chi-bot ti-chi-bot Bot merged commit a15c5e0 into pingcap:main Nov 28, 2025
6 checks passed
@djshow832 djshow832 deleted the log_finish branch November 28, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replay quits immediately after replay was paused in the service mode

3 participants