Skip to content

Conversation

@lucklove
Copy link
Member

Fix #1258

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2021
@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #1259 (2cd086e) into master (9049356) will increase coverage by 22.85%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1259       +/-   ##
===========================================
+ Coverage   26.21%   49.06%   +22.85%     
===========================================
  Files         263      289       +26     
  Lines       18898    20852     +1954     
===========================================
+ Hits         4954    10232     +5278     
+ Misses      13172     8984     -4188     
- Partials      772     1636      +864     
Flag Coverage Δ
cluster 38.29% <0.00%> (?)
dm 26.67% <0.00%> (?)
integrate 43.41% <0.00%> (+26.89%) ⬆️
playground 3.10% <ø> (?)
tiup 16.52% <0.00%> (-0.01%) ⬇️
unittest 22.74% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/checkpoint/checkpoint.go 72.50% <100.00%> (+20.60%) ⬆️
pkg/cluster/operation/action.go 59.31% <0.00%> (ø)
pkg/cluster/operation/check.go 0.00% <0.00%> (ø)
pkg/cluster/operation/telemetry.go 0.00% <0.00%> (ø)
components/dm/task/update_dm_meta.go 85.29% <0.00%> (ø)
components/playground/instance/tidb.go 0.00% <0.00%> (ø)
components/playground/instance/tikv_config.go 0.00% <0.00%> (ø)
pkg/cluster/operation/destroy.go 51.86% <0.00%> (ø)
components/playground/instance/tiflash.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 0.00% <0.00%> (ø)
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9049356...2cd086e. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: aeebb50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2021
@AstroProfundis AstroProfundis added this to the v1.4.1 milestone Apr 3, 2021
@ti-chi-bot ti-chi-bot merged commit c211098 into pingcap:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replay command reports "bufio.Scanner: token too long"

4 participants