Skip to content

Conversation

@AstroProfundis
Copy link
Contributor

What problem does this PR solve?

The indent of TLS encryption: enabled line in display output is incorrect

What is changed and how it works?

Replace the tab with whitespace

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: fix wrong indent in display for TLS enabled clusters

@AstroProfundis AstroProfundis added this to the v1.4.5 milestone May 27, 2021
@AstroProfundis AstroProfundis requested a review from lucklove May 27, 2021 06:59
@AstroProfundis AstroProfundis self-assigned this May 27, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #1390 (800d4d5) into master (e895fa7) will increase coverage by 28.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1390       +/-   ##
===========================================
+ Coverage   25.27%   54.17%   +28.89%     
===========================================
  Files         266      291       +25     
  Lines       20586    22469     +1883     
===========================================
+ Hits         5204    12172     +6968     
+ Misses      14582     8368     -6214     
- Partials      800     1929     +1129     
Flag Coverage Δ
cluster 41.89% <100.00%> (?)
dm 24.53% <0.00%> (?)
integrate 48.72% <100.00%> (+33.19%) ⬆️
playground 13.74% <ø> (?)
tiup 15.50% <ø> (-0.03%) ⬇️
unittest 21.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager/display.go 72.13% <100.00%> (+72.13%) ⬆️
pkg/repository/store/txn.go 59.09% <0.00%> (-2.28%) ⬇️
components/playground/instance/instance.go 45.45% <0.00%> (ø)
pkg/cluster/operation/check.go 46.70% <0.00%> (ø)
pkg/logger/logger.go 100.00% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 81.81% <0.00%> (ø)
... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e895fa7...800d4d5. Read the comment docs.

@AstroProfundis AstroProfundis modified the milestones: v1.4.5, v1.5.0 Jun 2, 2021
@lucklove
Copy link
Member

lucklove commented Jun 3, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@lucklove: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lucklove
Copy link
Member

lucklove commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@lucklove: /merge in this pull request requires 1 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@AstroProfundis
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d44f1b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@ti-chi-bot ti-chi-bot merged commit 3c716a3 into pingcap:master Jun 4, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.4.5, v1.5.0 Jun 7, 2021
@AstroProfundis AstroProfundis deleted the fix-display branch June 9, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants