Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Jun 4, 2021

What problem does this PR solve?

Updating the dependencies. Done with. go get -u

Release notes:

NONE

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 4, 2021
@AstroProfundis AstroProfundis added this to the v1.5.0 milestone Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7a443b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #1407 (b230162) into master (3c716a3) will increase coverage by 16.55%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1407       +/-   ##
===========================================
+ Coverage   25.33%   41.89%   +16.55%     
===========================================
  Files         266      226       -40     
  Lines       20611    17838     -2773     
===========================================
+ Hits         5222     7473     +2251     
+ Misses      14586     9084     -5502     
- Partials      803     1281      +478     
Flag Coverage Δ
cluster 41.89% <8.33%> (?)
integrate 41.89% <8.33%> (+26.40%) ⬆️
tiup ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/cluster/command/template.go 25.00% <8.33%> (-5.00%) ⬇️
pkg/utils/regexp.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/store/store.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/repository/utils/hash.go 0.00% <0.00%> (-81.82%) ⬇️
pkg/meta/err.go 0.00% <0.00%> (-81.25%) ⬇️
pkg/utils/semver.go 5.21% <0.00%> (-80.00%) ⬇️
pkg/cluster/api/error.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/telemetry/telemetry.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/repository/store/local.go 0.00% <0.00%> (-76.48%) ⬇️
pkg/telemetry/node_info.go 0.00% <0.00%> (-73.34%) ⬇️
... and 248 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1139f5d...b230162. Read the comment docs.

@AstroProfundis AstroProfundis merged commit 2cdadb5 into pingcap:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants