Skip to content

Conversation

@ekexium
Copy link
Member

@ekexium ekexium commented Jun 16, 2021

Signed-off-by: ekexium ekexium@gmail.com

What problem does this PR solve?

Fix a missing single quote in the help message.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release notes:

NONE

Signed-off-by: ekexium <ekexium@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot requested review from lonng and lucklove June 16, 2021 07:37
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #1429 (3c4bcdb) into master (89ebe5a) will increase coverage by 4.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   25.29%   29.93%   +4.64%     
==========================================
  Files         264      276      +12     
  Lines       20660    21083     +423     
==========================================
+ Hits         5226     6312    +1086     
+ Misses      14631    13794     -837     
- Partials      803      977     +174     
Flag Coverage Δ
integrate 21.70% <100.00%> (+6.24%) ⬆️
playground 13.73% <100.00%> (?)
tiup 15.45% <ø> (ø)
unittest 21.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/main.go 46.36% <100.00%> (+43.93%) ⬆️
components/playground/instance/tikv_config.go 100.00% <0.00%> (ø)
components/playground/instance/drainer.go 0.00% <0.00%> (ø)
components/playground/instance/pd.go 73.91% <0.00%> (ø)
components/playground/instance/tiflash.go 59.09% <0.00%> (ø)
components/playground/instance/tikv.go 67.34% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/playground/instance/process.go 81.39% <0.00%> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/ticdc.go 0.00% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ebe5a...3c4bcdb. Read the comment docs.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@AstroProfundis AstroProfundis added this to the v1.5.2 milestone Jun 16, 2021
@AstroProfundis AstroProfundis added the component/playground Issues about the tiup-playground component label Jun 16, 2021
@AstroProfundis
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: daca42d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@ti-chi-bot
Copy link
Member

@ekexium: Your PR was out of date, I have automatically updated it for you.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 342f044 into pingcap:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/playground Issues about the tiup-playground component size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants