Skip to content

Support router and resource manager services#2600

Merged
xhebox merged 5 commits intopingcap:masterfrom
rleungx:support-more-services
Dec 23, 2025
Merged

Support router and resource manager services#2600
xhebox merged 5 commits intopingcap:masterfrom
rleungx:support-more-services

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Sep 5, 2025

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.07%. Comparing base (9a7a5d2) to head (6e8ea0b).

Files with missing lines Patch % Lines
components/playground/playground.go 3.64% 49 Missing and 4 partials ⚠️
components/playground/instance/pd.go 11.11% 31 Missing and 1 partial ⚠️
components/playground/main.go 50.00% 6 Missing ⚠️
components/playground/instance/instance.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2600      +/-   ##
==========================================
- Coverage   39.14%   39.07%   -0.06%     
==========================================
  Files         356      356              
  Lines       36912    37022     +110     
==========================================
+ Hits        14446    14465      +19     
- Misses      20663    20748      +85     
- Partials     1803     1809       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rleungx rleungx changed the title Support router and admission control services Support router and resource manager services Sep 23, 2025
@rleungx rleungx marked this pull request as ready for review September 23, 2025 10:02
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025
@ti-chi-bot ti-chi-bot Bot requested a review from nexustar September 23, 2025 10:02
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 19, 2025

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 22, 2025

@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the support-more-services branch from 4e730dc to 3b2e36f Compare December 23, 2025 06:54
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot Bot added the lgtm label Dec 23, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Dec 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-23 09:21:58.104411241 +0000 UTC m=+2156062.918188803: ☑️ agreed by xhebox.

@xhebox xhebox merged commit 9338c69 into pingcap:master Dec 23, 2025
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants