feature/fts: merge master by Lloyd-Pottiger · Pull Request #2650 · pingcap/tiup

Lloyd-Pottiger · 2025-11-24T03:25:26Z

What problem does this PR solve?

close #xxx

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

* Telemetry removal * Remove left over teleCommand

…ap#2550) Signed-off-by: xhe <xw897002528@gmail.com>

* env: clean up old code Signed-off-by: xhe <xw897002528@gmail.com> * repo: leverage all apis into v1_repository Signed-off-by: xhe <xw897002528@gmail.com> * repo: abstract it as an interface Signed-off-by: xhe <xw897002528@gmail.com> * clean the remained part Signed-off-by: xhe <xw897002528@gmail.com> * rename to LocalComponentInstalled Signed-off-by: xhe <xw897002528@gmail.com> * update Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

Signed-off-by: xhe <xw897002528@gmail.com>

* cluster: improve SELinux compatibility * fixup

* Update --ssh desc * Update components/cluster/command/root.go --------- Co-authored-by: xhe <xw897002528@gmail.com>

Signed-off-by: xhe <xw897002528@gmail.com>

* Move insight to tiup * Fix linting issues * Fix unused/gocritic/staticcheck issues

* check_to_require: cluster * Restore TestCountDirMultiPath --------- Co-authored-by: xhe <xw897002528@gmail.com>

* Update dmpb * Remove dm grpc gw

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

@wuhuizuo

* ci: fix STAGING version competition * ci: replace slashes with dots in branch name for STAGING_VER * Apply suggestion from @wuhuizuo

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

…ify/require (pingcap#2570)

* Switch from yaml.v2 to yaml.v3 * Use KnownFields * Use KnowFields for a few more places that previously had UnmarshalStrict * Fix issues found by make check * Formatting differences in yaml * update * fix CI Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com>

* cluster: support new ready api for PD Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

* cluster: clear leader_priority for pd leader if exist Signed-off-by: xhe <xw897002528@gmail.com> * fix Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

* cluster: prompt for instance restart * Add comment * fixup * fixup * Split precheck from Upgrade

Signed-off-by: xhe <xw897002528@gmail.com>

* playground: fix metafile location * g Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com>

Signed-off-by: xhe <xw897002528@gmail.com>

* playground: dont request mirror when binpath specified Signed-off-by: xhe <xw897002528@gmail.com> * add tikv worker Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

* playground: refine nextgen version resolve Signed-off-by: xhe <xw897002528@gmail.com> * playgroud: support tiflash Signed-off-by: xhe <xw897002528@gmail.com> * fix version Signed-off-by: xhe <xw897002528@gmail.com> * fix Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

* cluster: cleanup ansible import related things * revert back missing code Signed-off-by: xhe <xw897002528@gmail.com> * fix test Signed-off-by: xhe <xw897002528@gmail.com> * remove ansible test Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com>

Signed-off-by: xhe <xw897002528@gmail.com>

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot · 2025-11-24T03:25:31Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-commenter · 2025-11-24T03:27:02Z

Codecov Report

❌ Patch coverage is 45.51724% with 316 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/fts@c5e8cee). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
components/playground/playground.go	43.09%	82 Missing and 21 partials ⚠️
components/playground/main.go	64.86%	25 Missing and 1 partial ⚠️
components/playground/instance/tiflash_config.go	0.00%	21 Missing ⚠️
components/playground/instance/tici.go	0.00%	19 Missing ⚠️
components/playground/instance/tidb_config.go	12.50%	14 Missing ⚠️
components/playground/instance/tikv_config.go	6.67%	14 Missing ⚠️
pkg/cluster/operation/destroy.go	0.00%	13 Missing ⚠️
pkg/exec/run.go	61.29%	8 Missing and 4 partials ⚠️
components/playground/instance/tikv_worker.go	0.00%	11 Missing ⚠️
pkg/repository/v1_repository.go	46.67%	8 Missing ⚠️
... and 30 more

Additional details and impacted files

@@              Coverage Diff               @@
##             feature/fts    #2650   +/-   ##
==============================================
  Coverage               ?   40.95%           
==============================================
  Files                  ?      370           
  Lines                  ?    37746           
  Branches               ?        0           
==============================================
  Hits                   ?    15457           
  Misses                 ?    20373           
  Partials               ?     1916

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

dveeden and others added 30 commits July 24, 2025 10:51

pkg/set: convert check to require (pingcap#2557)

ee17745

meta: replace pingcap/check with testing (pingcap#2559)

db8bc30

embed: replace pingcap/check with testing (pingcap#2555)

122e47c

base52: replace pingcap/check with testing (pingcap#2556)

25c571d

localdata: replace pingcap/check with testing (pingcap#2561)

88a64ad

utils: replace pingcap/check with testing (pingcap#2562)

bf4ad1f

telemetry: remove (pingcap#2564)

97a3aa7

* Telemetry removal * Remove left over teleCommand

repo: exclude prerelease version from version list if possible (pingc…

031a8ea

…ap#2550) Signed-off-by: xhe <xw897002528@gmail.com>

cluster: also check exporter ports (pingcap#2563)

4b06d03

Signed-off-by: xhe <xw897002528@gmail.com>

cluster: improve SELinux compatibility (pingcap#2501)

11b3c12

* cluster: improve SELinux compatibility * fixup

cluster: update --ssh desc (pingcap#2380)

7f4b505

* Update --ssh desc * Update components/cluster/command/root.go --------- Co-authored-by: xhe <xw897002528@gmail.com>

cluster: add stop/start timeout for systemd service (pingcap#2568)

6282d0d

Signed-off-by: xhe <xw897002528@gmail.com>

*: move insight to tiup (pingcap#2553)

97eb4d7

* Move insight to tiup * Fix linting issues * Fix unused/gocritic/staticcheck issues

*: check_to_require for cluster (pingcap#2566)

f2a5db1

* check_to_require: cluster * Restore TestCountDirMultiPath --------- Co-authored-by: xhe <xw897002528@gmail.com>

*: update dmpb (pingcap#2569)

d2f2267

* Update dmpb * Remove dm grpc gw

*: replace otiai10/copy with os.CopyFS (pingcap#2571)

f57cbe3

ci: add staging mirror option to release workflow (pingcap#2576)

8509f60

ci: fix STAGING version competition (pingcap#2579)

22060bb

playground: fix config typo (pingcap#2578)

67b528d

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ci: add ci for feature branch (pingcap#2577)

e7bbbeb

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ci: fix staging version string (pingcap#2582)

8db1656

* ci: fix STAGING version competition * ci: replace slashes with dots in branch name for STAGING_VER * Apply suggestion from @wuhuizuo

playground: fix tiflash metric (pingcap#2587)

fac6dd6

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

*: Replace github.com/alecthomas/assert with github.com/stretchr/test…

e446891

…ify/require (pingcap#2570)

cluster: clear leader_priority for pd leader if exist (pingcap#2591)

f9d0d1b

* cluster: clear leader_priority for pd leader if exist Signed-off-by: xhe <xw897002528@gmail.com> * fix Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

cluster: prompt for instance restart (pingcap#2513)

bce3005

* cluster: prompt for instance restart * Add comment * fixup * fixup * Split precheck from Upgrade

bump version to 1.16.3 (pingcap#2593)

365c08e

Signed-off-by: xhe <xw897002528@gmail.com>

*: Modernize (pingcap#2574)

3d09deb

dveeden and others added 21 commits November 11, 2025 10:42

CI: update and fix integrate-dm (pingcap#2643)

3ec3c6f

playground: fix metafile location (pingcap#2638)

eb46552

* playground: fix metafile location * g Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com>

Upgrade usql (pingcap#2595)

c57cefb

cluster: fix instance level timeout stop (pingcap#2644)

7db1c7f

Signed-off-by: xhe <xw897002528@gmail.com>

playground: dont request mirror when binpath specified (pingcap#2645)

23ed2b9

* playground: dont request mirror when binpath specified Signed-off-by: xhe <xw897002528@gmail.com> * add tikv worker Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com>

*: cleanup unit test generated data (pingcap#2647)

c0b8fee

*: add option to force redownload binaries (pingcap#2648)

9a25057

Signed-off-by: xhe <xw897002528@gmail.com>

playground: fix nextgen install (pingcap#2649)

7dfba3f

Merge branch 'master' into merge-master

85571ee

fix: merge master and fix build errors

fa17c16

fix: resolve merge conflicts and fix build errors

c0c5208

fix: resolve merge conflicts and fix build and linting errors

7214521

fix

f0dca06

fix

6ed8910

fix

507d3c4

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix

c924939

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix

b4b1824

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix

ab736c6

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix

ced4efe

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot Bot requested review from breezewish and nexustar November 24, 2025 03:25

ti-chi-bot Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 24, 2025

Lloyd-Pottiger added 2 commits November 24, 2025 11:34

fix

5cd9116

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix

8f7ab5c

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

xhebox merged commit 5e178b3 into pingcap:feature/fts Nov 24, 2025
6 of 7 checks passed

Lloyd-Pottiger deleted the merge-master branch November 24, 2025 03:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature/fts: merge master#2650

feature/fts: merge master#2650
xhebox merged 72 commits intopingcap:feature/ftsfrom
Lloyd-Pottiger:merge-master

Lloyd-Pottiger commented Nov 24, 2025

Uh oh!

ti-chi-bot Bot commented Nov 24, 2025

Uh oh!

codecov-commenter commented Nov 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

Lloyd-Pottiger commented Nov 24, 2025

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

ti-chi-bot Bot commented Nov 24, 2025

Uh oh!

codecov-commenter commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov-commenter commented Nov 24, 2025 •

edited

Loading