Feature: don't reload prometheus if the scaled comp is itself

[9547]

What problem does this PR solve?

fix #944

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Code changes

• Has exported function/method change
• Has exported variable/fields change
• Has interface methods change
• Has persistent data change

Side effects

• Possible performance regression
• Increased code complexity
• Breaking backward compatibility

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release notes:

NONE

[codecov-io]

Codecov Report

Merging #989 (1022823) into master (7668e42) will decrease coverage by 6.87%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   55.48%   48.60%   -6.88%     
==========================================
  Files         279      279              
  Lines       19710    19719       +9     
==========================================
- Hits        10936     9585    -1351     
- Misses       7061     8618    +1557     
+ Partials     1713     1516     -197     

Flag	Coverage Δ
cluster	31.75% <100.00%> (-11.59%)	⬇️
dm	23.91% <45.00%> (+0.07%)	⬆️
integrate	42.06% <100.00%> (-7.69%)	⬇️
playground	20.28% <ø> (ø)
tiup	16.46% <ø> (ø)
unittest	23.05% <9.52%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/cluster/command/patch.go	50.00% <100.00%> (-20.00%)	⬇️
components/dm/command/patch.go	50.00% <100.00%> (ø)
pkg/cluster/manager/builder.go	82.19% <100.00%> (-3.01%)	⬇️
pkg/cluster/manager/destroy.go	64.78% <100.00%> (-4.33%)	⬇️
pkg/cluster/manager/scale_in.go	59.52% <100.00%> (ø)
pkg/cluster/task/builder.go	69.00% <100.00%> (-28.10%)	⬇️
pkg/cluster/task/update_meta.go	72.30% <100.00%> (-4.62%)	⬇️
pkg/cluster/task/update_topology.go	71.15% <100.00%> (+3.84%)	⬆️
pkg/cluster/template/config/config.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/template/scripts/scripts.go	0.00% <0.00%> (-100.00%)	⬇️
... and 67 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7668e42...1022823. Read the comment docs.

[lucklove]

There are two test cases failed, both on scale-out promethues and waiting the instance number. I retried the test and it still failed, I think it's not a coincidence.

[lucklove]

/merge

[ti-chi-bot]

Can merge label has been added.

Details

Git tree hash: 1022823