Skip to content

Comments

feat: add minute second inputs for offset#40

Merged
markflorkowski merged 8 commits intopingdotgg:mainfrom
jackblatch:main
Apr 7, 2023
Merged

feat: add minute second inputs for offset#40
markflorkowski merged 8 commits intopingdotgg:mainfrom
jackblatch:main

Conversation

@jackblatch
Copy link
Contributor

@jackblatch jackblatch commented Apr 5, 2023

This changes the offset input to two inputs allowing for minutes and seconds to be entered, rather than just seconds.
#41

@vercel
Copy link

vercel bot commented Apr 5, 2023

@jackblatch is attempting to deploy a commit to the Ping Labs Team on Vercel.

A member of the Team first needs to authorize it.

@markflorkowski
Copy link
Contributor

Would you mind including a screenshot since this is a visual change?

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
markerthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2023 9:33pm

@jackblatch
Copy link
Contributor Author

jackblatch commented Apr 6, 2023

@markflorkowski I've added the feature into a single input now. Let me know what you think. Do you have any preference on what the input suffix should say with this update (as it's not always shown as seconds anymore)?

offset input

@markflorkowski
Copy link
Contributor

@markflorkowski I've added the feature into a single input now. Let me know what you think. Do you have any preference on what the input suffix should say with this update (as it's not always shown as seconds anymore)?

offset input

I think we can either

A) remove the suffix

or

B) hide it as soon as the user enters a : in the field

Personally leaning towards (A), @t3dotgg do you have an opinion?

Co-authored-by: woven ink <55413049+flbn@users.noreply.github.com>
@markflorkowski
Copy link
Contributor

Talked to Theo, he seems in agreement that removing the suffix is sufficient.

@jackblatch
Copy link
Contributor Author

Sure, that's done now.

@markflorkowski markflorkowski merged commit 8e9b20c into pingdotgg:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants