You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Proposal: opt-in English / Simplified Chinese language catalogs on V2
#15179
Would maintainers approve a shared data-only locale foundation and opt-in Simplified Chinese for Web/Electron? English remains the default; user/model/provider/path/command values remain untouched.
I read CONTRIBUTING.md#prior-approval and have not opened a PR without explicit approval. Related PRs: #10900 (closed for missing scope/default-language approval) and #14215 (closed during the V2 transition). This candidate is based on current V2 main 31a9da1. Those closure comments are context, not approval.
Proposed scope: shared en.json/zh-CN.json and pure lookup/interpolation with English fallback; persisted client-only language setting; live React switching; native Electron menus; no locale auto-detection or default-language change. React Native is a separate future scope only if approved.
The full integration necessarily touches many UI call sites, not only two JSON files. I can split review into runtime/setting/catalog foundation, Web integration, and native menus after scope approval. DSH integration, backend orchestration, signing, updater/release changes and local installation records are excluded.
Verification: four relevant package typechecks pass; 168 Web and 23 shared/Desktop tests pass; 3 audit negative tests pass; 4,334 catalog keys and production display scan report zero errors. Fresh before/after GUI evidence for this clean branch has not been captured, so it is not claimed PR-ready.
Is this opt-in direction and scope acceptable? Would you prefer a staged rollout or one complete locale integration?
Lint: all changed files report 350 warnings and zero errors after removing an unrelated legacy test regression from the extraction. Upstream test semantics are preserved.
The candidate touches 312 files, primarily display call sites plus the catalogs. It is a reference implementation for deciding scope, not a request to review a large unapproved PR. I will follow the rollout and catalog conventions maintainers prefer.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Would maintainers approve a shared data-only locale foundation and opt-in Simplified Chinese for Web/Electron? English remains the default; user/model/provider/path/command values remain untouched.
I read CONTRIBUTING.md#prior-approval and have not opened a PR without explicit approval. Related PRs: #10900 (closed for missing scope/default-language approval) and #14215 (closed during the V2 transition). This candidate is based on current V2 main 31a9da1. Those closure comments are context, not approval.
Proposed scope: shared en.json/zh-CN.json and pure lookup/interpolation with English fallback; persisted client-only language setting; live React switching; native Electron menus; no locale auto-detection or default-language change. React Native is a separate future scope only if approved.
The full integration necessarily touches many UI call sites, not only two JSON files. I can split review into runtime/setting/catalog foundation, Web integration, and native menus after scope approval. DSH integration, backend orchestration, signing, updater/release changes and local installation records are excluded.
Verification: four relevant package typechecks pass; 168 Web and 23 shared/Desktop tests pass; 3 audit negative tests pass; 4,334 catalog keys and production display scan report zero errors. Fresh before/after GUI evidence for this clean branch has not been captured, so it is not claimed PR-ready.
Is this opt-in direction and scope acceptable? Would you prefer a staged rollout or one complete locale integration?
Lint: all changed files report 350 warnings and zero errors after removing an unrelated legacy test regression from the extraction. Upstream test semantics are preserved.
Candidate for scope review
The candidate touches 312 files, primarily display call sites plus the catalogs. It is a reference implementation for deciding scope, not a request to review a large unapproved PR. I will follow the rollout and catalog conventions maintainers prefer.
All reactions