You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Link a pull request from a thread's right-click menu
#15497
A thread's right-click menu has no way to link a pull request. The link dialog already exists. You can open it from the command palette's Link pull request to thread command, by right-clicking a PR link in the conversation, or with Link to thread on the Pull Requests page. The Linked pull requests panel has a Link pull request button, but the panel stays disabled until the thread has at least one link.
I looked for this in the thread's right-click menu first, next to Pin thread and Rename thread, and it wasn't there.
Proposal
Add Link pull request… to the thread action menu, below Regenerate title. The sidebar row and the chat header build their menus from the same list in threadActionMenu.logic.ts, so both get the item. It opens the existing link dialog, which accepts a URL or #123. The item appears only when the environment supports PR linking. Unsent drafts keep their own menu and don't get it.
The change also moves LinkPullRequestDialogHost from ChatView to the app root, next to CustomSnoozeDialogHost. The sidebar also shows on the Pull Requests page and the home route, which have no ChatView. Without the move, the item opens nothing on those routes.
It changes 9 files in apps/web and two user guides, thread-sidebar.md and source-control.md. It has no server or contract changes. Mobile has no linking UI, so it stays as it is. I tested it with the focused menu tests, the web typecheck, and a dev server. In the dev server, I linked a PR from the sidebar menu. I also opened the dialog from the chat header menu, the Pull Requests page, and the command palette.
The change doesn't affect stale branch-detected PRs (#4970, #14858). It makes explicit linking easier to find and nothing else.
Question
Would you take this as a PR? If you prefer another fix, I can change the branch to enable the Linked pull requests panel for threads with no links instead. That would make its existing Link pull request button reachable.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Problem
A thread's right-click menu has no way to link a pull request. The link dialog already exists. You can open it from the command palette's Link pull request to thread command, by right-clicking a PR link in the conversation, or with Link to thread on the Pull Requests page. The Linked pull requests panel has a Link pull request button, but the panel stays disabled until the thread has at least one link.
I looked for this in the thread's right-click menu first, next to Pin thread and Rename thread, and it wasn't there.
Proposal
Add Link pull request… to the thread action menu, below Regenerate title. The sidebar row and the chat header build their menus from the same list in
threadActionMenu.logic.ts, so both get the item. It opens the existing link dialog, which accepts a URL or#123. The item appears only when the environment supports PR linking. Unsent drafts keep their own menu and don't get it.The change also moves
LinkPullRequestDialogHostfromChatViewto the app root, next toCustomSnoozeDialogHost. The sidebar also shows on the Pull Requests page and the home route, which have noChatView. Without the move, the item opens nothing on those routes.Before:
After:
After linking
#15457from the menu:Branch
The change is ready on a branch based on current
main:main...arun279:t3code:feat/sidebar-link-pull-request
It changes 9 files in
apps/weband two user guides,thread-sidebar.mdandsource-control.md. It has no server or contract changes. Mobile has no linking UI, so it stays as it is. I tested it with the focused menu tests, the web typecheck, and a dev server. In the dev server, I linked a PR from the sidebar menu. I also opened the dialog from the chat header menu, the Pull Requests page, and the command palette.The change doesn't affect stale branch-detected PRs (#4970, #14858). It makes explicit linking easier to find and nothing else.
Question
Would you take this as a PR? If you prefer another fix, I can change the branch to enable the Linked pull requests panel for threads with no links instead. That would make its existing Link pull request button reachable.
All reactions