Repository navigation
Delegated children are told never to watch their PR, so nobody follows CI on a child's fix PR #25650
Closed
juliusmarminge
started this conversation in
Ideas
Replies: 1 comment
|
This is a bug rather than an idea; it was converted here by an automated triage lead by mistake. Re-filed as #25764. Closing this discussion in favour of the issue. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What happened
T3 injects this into every provider's system prompt (
<pull_request_linking>):So a delegated child that opens a fix PR always ends its turn without
watch_pull_request, even when its task explicitly says to watch the PR, fix CI and report when it's green. Nobody follows up on CI for that PR unless the parent builds its own polling.In the fleet (Issue Triager and PR Takeovers dispatchers on nucbox-1, leads on 40 linked VMs), leads' briefs say to watch the fix PR, fix CI and add
bugfixwhen it's green. The dispatchers resolved the conflict in favour of this rule. Since 2026-10-24, about 1,200 lead dispatches carried "do not watch", and 184 fix PRs from issue leads have no CI follow-up record.Expected
Julius has decided that the lead that opens a fix PR owns its CI follow-up through a PR watch. So:
watch_pull_requeston its own PR when its task asks for it. The injected instructions should say "watch only when your task asks for it" instead of "never".task_statussays the child holds a PR watch on , so the parent doesn't treat the child's interim result as final.Where
packages/provider-core/src/server/runtimeInstructions.ts:1-3(PULL_REQUEST_LINKING_INSTRUCTIONS, origin/mainfe507c5a1e). The rule exists only in this prompt text;watch_pull_requestitself (apps/server/src/mcp/toolkits/pullRequests/tools.ts:309) doesn't restrict children.Related: https://git.cafe/pingdotgg/t3code/issues/24326, https://git.cafe/pingdotgg/t3code/issues/24297, https://git.cafe/pingdotgg/t3code/issues/22183 (watch ends silently).
All reactions