fix: tighten node engine range for node:sqlite compat (#206)#1096
Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom Mar 15, 2026
Merged
fix: tighten node engine range for node:sqlite compat (#206)#1096juliusmarminge merged 2 commits intopingdotgg:mainfrom
juliusmarminge merged 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
juliusmarminge
approved these changes
Mar 15, 2026
gabrielMalonso
pushed a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 15, 2026
…pingdotgg#1096) Co-authored-by: Julius Marminge <julius0216@outlook.com>
3 tasks
gabrielMalonso
added a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 15, 2026
* chore: add .idea/ to .gitignore (pingdotgg#1077) * Fixed Typos in Agents.md (pingdotgg#1120) * fix: tighten node engine range for node:sqlite compat (pingdotgg#206) (pingdotgg#1096) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): unify focus ring styles across sidebar and app (pingdotgg#1079) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * feat(web): add scroll to bottom pill in chat view (pingdotgg#619) * chore: adiciona skill upstream-sync para monitorar atualizacoes do repositorio * fix: format upstream-sync skill file for oxfmt check Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Stefan Wintergerst <wintergerst.stefan@googlemail.com> Co-authored-by: Ivor <harshgamer6351@gmail.com> Co-authored-by: Etan Heyman <93338119+EtanHey@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Xanacas <53140620+Xanacas@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Sai Shankar <saishankar2803@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Tightened
engines.nodefrom^22.13 || ^23.4to^22.16 || ^23.11 || >=24.10and added a runtime version check inSqlite.tsbefore loadingnode:sqlite.Why
StatementSync.columns()(used inNodeSqliteClient.ts) was only added in Node 22.16 / 23.11. The previous engine range allowed 22.13+, so users on those versions crash withTypeError: statement.columns is not a function.The runtime check is needed because
npx t3@alphaskips engine checks. Gated onruntime === "node"so Bun is untouched.Addresses #206
Checklist
bun lint— cleanbun typecheck— server cleanbun run test— 446 passedNote
Enforce minimum Node.js versions for
node:sqlitecompatibility inNodeSqliteClientengines.nodeconstraint in package.json from^22.13 || ^23.4 || >=24.10to^22.16 || ^23.11 || >=24.10to match the versions wherenode:sqliteAPIs are stable.checkNodeSqliteCompathelper in NodeSqliteClient.ts that parsesprocess.versions.nodeat runtime and callsEffect.diewith a descriptive message if the version is unsupported.makeWithDatabasenow runs this check before opening the database, aborting initialization on incompatible Node versions.Macroscope summarized b2a41a9.