Merged
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable virtualization for the currently in-progress turn to prevent height calculation issues and collisions during streaming.
Note
Virtualize only pre-turn rows in
MessagesTimelineand pass active turn state fromChatViewto support current turn virtualizationAdd
activeTurnInProgressandactiveTurnStartedAtprops toMessagesTimeline; computefirstUnvirtualizedRowIndexand usevirtualizedRowCountto split rendering between virtualized past rows and non-virtualized current turn, with a timestampedworkingrow. Minor JSX formatting update inMessageCopyButton. See ChatView.tsx and MessagesTimeline.tsx.📍Where to Start
Start with the virtualization split and
firstUnvirtualizedRowIndexlogic in MessagesTimeline.tsx.Macroscope summarized 88ab776.
Note
Medium Risk
Changes chat timeline virtualization and row rendering during in-progress turns, which can affect scrolling behavior and message/work log layout while streaming. Risk is limited to UI/UX but could introduce regressions in virtual list sizing or auto-scroll.
Overview
Prevents virtualized rendering for the currently in-progress turn in
ChatViewto avoid height/measurement issues during streaming.MessagesTimelinenow receivesactiveTurnInProgress/activeTurnStartedAt, stamps rows withcreatedAt, computes a split index for the active turn, virtualizes only the earlier rows, and renders the remainder (including the working indicator/current turn) non-virtualized. Minor refactor extracts shared row rendering (renderRowContent) and addsclampto bound the virtualized row count.Written by Cursor Bugbot for commit 88ab776. This will update automatically on new commits. Configure here.