Skip to content

Current turn virtualization#118

Merged
juliusmarminge merged 2 commits intomainfrom
cursor/current-turn-virtualization-d1ab
Feb 28, 2026
Merged

Current turn virtualization#118
juliusmarminge merged 2 commits intomainfrom
cursor/current-turn-virtualization-d1ab

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Feb 28, 2026

Disable virtualization for the currently in-progress turn to prevent height calculation issues and collisions during streaming.


Open in Web Open in Cursor 

Note

Virtualize only pre-turn rows in MessagesTimeline and pass active turn state from ChatView to support current turn virtualization

Add activeTurnInProgress and activeTurnStartedAt props to MessagesTimeline; compute firstUnvirtualizedRowIndex and use virtualizedRowCount to split rendering between virtualized past rows and non-virtualized current turn, with a timestamped working row. Minor JSX formatting update in MessageCopyButton. See ChatView.tsx and MessagesTimeline.tsx.

📍Where to Start

Start with the virtualization split and firstUnvirtualizedRowIndex logic in MessagesTimeline.tsx.

Macroscope summarized 88ab776.


Note

Medium Risk
Changes chat timeline virtualization and row rendering during in-progress turns, which can affect scrolling behavior and message/work log layout while streaming. Risk is limited to UI/UX but could introduce regressions in virtual list sizing or auto-scroll.

Overview
Prevents virtualized rendering for the currently in-progress turn in ChatView to avoid height/measurement issues during streaming.

MessagesTimeline now receives activeTurnInProgress/activeTurnStartedAt, stamps rows with createdAt, computes a split index for the active turn, virtualizes only the earlier rows, and renders the remainder (including the working indicator/current turn) non-virtualized. Minor refactor extracts shared row rendering (renderRowContent) and adds clamp to bound the virtualized row count.

Written by Cursor Bugbot for commit 88ab776. This will update automatically on new commits. Configure here.

Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
@cursor
Copy link
Copy Markdown
Contributor

cursor bot commented Feb 28, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 28, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/current-turn-virtualization-d1ab

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliusmarminge juliusmarminge marked this pull request as ready for review February 28, 2026 03:11
@juliusmarminge juliusmarminge merged commit aa267eb into main Feb 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants