Skip to content

Use secret release app ID in release workflow#1217

Merged
juliusmarminge merged 1 commit intomainfrom
t3code/fix-github-app-token
Mar 20, 2026
Merged

Use secret release app ID in release workflow#1217
juliusmarminge merged 1 commit intomainfrom
t3code/fix-github-app-token

Conversation

@juliusmarminge
Copy link
Member

@juliusmarminge juliusmarminge commented Mar 20, 2026

Summary

  • Switch the release workflow to read RELEASE_APP_ID from secrets instead of repository variables.
  • Keep the release app private key sourced from secrets as before.
  • Align token minting with the existing secret-based release credential flow.

Testing

  • Not run (workflow-only change).
  • Reviewed .github/workflows/release.yml diff for the token minting input update.

Note

Read release app ID from secrets context in release workflow

Changes the app-id input for the 'Mint release app token' step in release.yml from vars.RELEASE_APP_ID to secrets.RELEASE_APP_ID, treating the app ID as a secret rather than a public variable.

Macroscope summarized e9de9fc.

- Read the GitHub App ID from secrets instead of vars
- Keep the private key sourced from secrets
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4c7c69ad-070e-4950-bb0c-79412bc941ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/fix-github-app-token
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the size:XS 0-9 changed lines (additions + deletions). label Mar 20, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 20, 2026 03:12
@github-actions github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 20, 2026
@juliusmarminge juliusmarminge disabled auto-merge March 20, 2026 03:13
@juliusmarminge juliusmarminge enabled auto-merge (squash) March 20, 2026 03:13
@juliusmarminge juliusmarminge merged commit 2a237c2 into main Mar 20, 2026
10 checks passed
@juliusmarminge juliusmarminge deleted the t3code/fix-github-app-token branch March 20, 2026 03:14
aaditagrawal pushed a commit to aaditagrawal/t3code that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant