Add clickable PR status tooltip in sidebar thread list#125
Merged
juliusmarminge merged 3 commits intomainfrom Mar 1, 2026
Merged
Add clickable PR status tooltip in sidebar thread list#125juliusmarminge merged 3 commits intomainfrom
juliusmarminge merged 3 commits intomainfrom
Conversation
- Show PR number/title in a tooltip on each thread PR icon - Open PR links externally from the sidebar and show error toasts on failure - Improve thread row keyboard handling after switching to a non-button render Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is ON, but it could not run because the spend limit has been reached. To enable Bugbot Autofix, raise your spend limit in the Cursor dashboard.
- Stop throwing when `window.open` returns `null` in `wsNativeApi` - Keep opening external links in a new tab and rely on browser popup policy
- Drop `title` from the PR status button in `Sidebar` to avoid duplicate tooltip text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#<number> <state>: <title>) and render it viaTooltipnativeApi.shell.openExternalEnter/SpacenavigationTesting
EnterandSpaceon a focused thread row navigate to that threadopenExternalrejectsNote
Medium Risk
Touches sidebar navigation interactions and external link opening behavior; regressions could break thread navigation or PR link launching across browsers.
Overview
Adds a clickable PR status indicator to the sidebar thread list: per-thread git status mapping now retains full PR metadata (state/number/title/url) and renders a tooltip with that detail; clicking the PR icon opens the PR via
nativeApi.shell.openExternalwith error toasts on failure.Improves thread row accessibility by making the row keyboard-activatable (Enter/Space) and adjusting the row render element. Updates
shell.openExternalto stop throwing whenwindow.openreturnsnull(to avoid false negatives on some mobile browsers).Written by Cursor Bugbot for commit fb5aee3. This will update automatically on new commits. Configure here.
Note
Add a clickable PR status tooltip to the sidebar thread list and wire button clicks to
api.shell.openExternalin Sidebar.tsxMake the PR indicator a focusable button with a tooltip and open the PR URL via the native API; refactor to pass the full PR object to
prStatusIndicatorand map threads to full PR data; adjustapi.shell.openExternalto always resolve in browser environments.📍Where to Start
Start with
Sidebarand theopenPrLinkhandler in Sidebar.tsx, then reviewprStatusIndicatorusage and the PR mapping memo; finally checkcreateWsNativeApiin wsNativeApi.ts.Macroscope summarized fb5aee3.