Flatten Git service layer and switch server paths to base dir#1255
Merged
juliusmarminge merged 5 commits intomainfrom Mar 24, 2026
Merged
Flatten Git service layer and switch server paths to base dir#1255juliusmarminge merged 5 commits intomainfrom
juliusmarminge merged 5 commits intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- remove the GitService layer and wire callers to GitCore directly - update checkpointing and orchestration wiring to provide GitCore - adjust git layer tests and harnesses for the new structure
d100711 to
e31a466
Compare
Chrono-byte
pushed a commit
to Chrono-byte/t3code
that referenced
this pull request
Mar 24, 2026
aaditagrawal
added a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 24, 2026
4 tasks
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 24, 2026
…draft threads, settings refactor Merges 18 upstream commits including: - feat: terminal toggle button in chat header (pingdotgg#633) - feat: resizable chat sidebar (pingdotgg#1347) - feat: stream git hook progress events (pingdotgg#1214) - feat: configurable base directory (pingdotgg#826) - feat: persist model options (pingdotgg#1121) - refactor: simplify settings layout (pingdotgg#1288) - refactor: flatten Git service layer (pingdotgg#1255) - fix: draft-thread project scripts (pingdotgg#1178) - fix: draft attachment persistence warnings (pingdotgg#1153) - fix: PTY adapter runtime loading (pingdotgg#1311) - fix: Claude SDK filesystem settings (pingdotgg#1334) - Various UI fixes and polish Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitCore, removing the separateGitServicelayer and updating downstream consumers and tests.T3CODE_HOME/--base-dir.Testing
bun fmt,bun lint,bun typecheck, andbun run test.Note
Replace GitService with GitCore as the primary git execution layer
GitServicefrom the runtime and test layers, makingGitCorethe single service responsible for executing git commands.executemethod toGitCoreShapethat spawns agitchild process with streamed stdout/stderr, a 30s default timeout, and a 1,000,000-byte per-stream output cap.GitCommandErrorunless explicitly permitted; timeouts and stream failures are also wrapped asGitCommandErrorwith operation, command, and cwd context.CheckpointStoreLiveno longer implicitly providesGitService; callers must now supplyGitCoreexplicitly.GitCommandErrorfor commands that previously succeeded with large output or slow execution.Macroscope summarized 5156493.