fix: serve project favicons with correct mime type#1313
fix: serve project favicons with correct mime type#1313sabraman wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can suggest fixes for GitHub Check annotations.Configure the |
Summary
Mime.getType(...)instead of a hand-written extension map.jpegicon discovered from project HTML metadataWhy
The project favicon proxy resolves arbitrary
rel="icon"hrefs from user projects. The original implementation used a smaller custom MIME map than the rest of the server, which caused.jpegfavicons to fall back toapplication/octet-stream.This change fixes the
.jpegcase and removes the duplicate MIME lookup logic so the favicon route stays aligned with the server's other file-serving paths.Verification