fix: add noopener to external chat markdown links#1315
Merged
juliusmarminge merged 3 commits intopingdotgg:mainfrom Mar 28, 2026
Merged
fix: add noopener to external chat markdown links#1315juliusmarminge merged 3 commits intopingdotgg:mainfrom
juliusmarminge merged 3 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
noopeneralongsidenoreferrerfor external links rendered byChatMarkdownWhy
Markdown links that do not resolve to local file targets open in a new tab from
ChatMarkdown, but they were the only new-tab links in the repo still usingrel="noreferrer"alone. The rest of the app and marketing site consistently userel="noopener noreferrer"for that pattern.Verification
Note
Add
noopenerto external links in chat markdown rendererUpdates the
arenderer in ChatMarkdown.tsx to includerel="noopener noreferrer"(previously onlynoreferrer) on external links opened in a new tab. This prevents the new page from accessingwindow.openeron the source tab.Macroscope summarized b0676a2.
Note
Low Risk
Low risk: a one-line security hardening change to anchor
relattributes for external links; no functional logic changes beyond link metadata.Overview
External links rendered by
ChatMarkdownthat open in a new tab now userel="noopener noreferrer"instead ofrel="noreferrer", preventing the opened page from accessingwindow.opener.Written by Cursor Bugbot for commit d5891f5. This will update automatically on new commits. Configure here.