fix(claude): avoid resetting the Claude model on every turn#1466
Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom Mar 27, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
juliusmarminge
approved these changes
Mar 27, 2026
aaditagrawal
pushed a commit
to aaditagrawal/t3code
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1381
This fixes a Claude adapter edge case where we were effectively re-selecting the same model over and over, which could add unnecessary control-message noise to the turn flow / context.
What changed
Why
For Claude, the raw model slug is not always the final API model id we send through, so the guard needs to compare the resolved value. That keeps us from doing extra model resets when nothing has really changed.
Validation
Note
Fix Claude adapter to skip
setModelcalls when the effective API model is unchangedAdds a
currentApiModelIdfield toClaudeSessionContextto track the API model currently applied to the session. InsendTurn, the adapter now compares the resolved API model againstcurrentApiModelIdand only callsquery.setModelwhen the model has actually changed, updatingcurrentApiModelIdafterward.Macroscope summarized c7a018b.