[codex] migrate Effect.fn in apps/server/src/checkpointing/Layers/CheckpointStore.ts#1623
Merged
juliusmarminge merged 1 commit intomainfrom Apr 1, 2026
Conversation
…tore.ts Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
() => Effect.gen(...)wrapper inapps/server/src/checkpointing/Layers/CheckpointStore.tstoEffect.fnWhy
Effect.genwrappers out of the codebaseValidation
bun fmtbun lintpackages/shared: bun run test src/DrainableWorker.test.tsapps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.tsapps/server: bun run test src/orchestration/projector.test.tsapps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"Notes
bun run testandbun typecheckat the repo root currently fail inapps/webbecause@effect/atom-reactcannot be resolvedapps/serverstill has unrelated pre-existing typecheck failures outside this fileNote
Migrate checkpoint functions in
CheckpointStore.tsto namedEffect.fnWraps
captureCheckpoint,restoreCheckpoint,diffCheckpoints, anddeleteCheckpointRefsin CheckpointStore.ts withEffect.fn("<name>")instead of anonymousEffect.gencalls. No logic, control flow, or error handling changes.Macroscope summarized 2e848bc.
Note
Low Risk
Pure refactor of checkpointing layer functions to use
Effect.fninstead of anonymousEffect.genwrappers, with no intended behavior changes. Risk is low and mainly limited to potential subtle differences in effect naming/stack traces.Overview
Migrates the remaining checkpointing operations in
CheckpointStore.tsfrom anonymousEffect.genwrappers to namedEffect.fnforms (including an innercaptureCheckpoint.withTempDirectory). This standardizes effect naming forcaptureCheckpoint,restoreCheckpoint,diffCheckpoints, anddeleteCheckpointRefswithout changing the underlying Git commands, control flow, or error handling.Written by Cursor Bugbot for commit 2e848bc. This will update automatically on new commits. Configure here.