Skip to content

[codex] migrate Effect.fn in apps/server/src/checkpointing/Layers/CheckpointStore.ts#1623

Merged
juliusmarminge merged 1 commit intomainfrom
codex/effect-fn-apps-server-src-checkpointing-layers-checkpointstore
Apr 1, 2026
Merged

[codex] migrate Effect.fn in apps/server/src/checkpointing/Layers/CheckpointStore.ts#1623
juliusmarminge merged 1 commit intomainfrom
codex/effect-fn-apps-server-src-checkpointing-layers-checkpointstore

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 1, 2026

Summary

  • migrate the remaining () => Effect.gen(...) wrapper in apps/server/src/checkpointing/Layers/CheckpointStore.ts to Effect.fn
  • keep this PR scoped to a single file as part of the checklist split

Why

  • finish the remaining checklist migrations without batching multiple files into one review
  • keep exact-empty-arg Effect.gen wrappers out of the codebase

Validation

  • bun fmt
  • bun lint
  • packages/shared: bun run test src/DrainableWorker.test.ts
  • apps/server: bun run test src/provider/Layers/EventNdjsonLogger.test.ts src/provider/Layers/ProviderRegistry.test.ts src/provider/Layers/ProviderService.test.ts src/provider/Layers/ProviderAdapterRegistry.test.ts src/keybindings.test.ts src/open.test.ts
  • apps/server: bun run test src/orchestration/projector.test.ts
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "returns deterministic read models for repeated reads"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "archives and unarchives threads through orchestration commands"
  • apps/server: bun run test src/orchestration/Layers/OrchestrationEngine.test.ts -t "streams persisted domain events in order"

Notes

  • validation was run from the completed checklist scratch branch before splitting these per-file PRs
  • bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
  • apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Migrate checkpoint functions in CheckpointStore.ts to named Effect.fn

Wraps captureCheckpoint, restoreCheckpoint, diffCheckpoints, and deleteCheckpointRefs in CheckpointStore.ts with Effect.fn("<name>") instead of anonymous Effect.gen calls. No logic, control flow, or error handling changes.

Macroscope summarized 2e848bc.


Note

Low Risk
Pure refactor of checkpointing layer functions to use Effect.fn instead of anonymous Effect.gen wrappers, with no intended behavior changes. Risk is low and mainly limited to potential subtle differences in effect naming/stack traces.

Overview
Migrates the remaining checkpointing operations in CheckpointStore.ts from anonymous Effect.gen wrappers to named Effect.fn forms (including an inner captureCheckpoint.withTempDirectory). This standardizes effect naming for captureCheckpoint, restoreCheckpoint, diffCheckpoints, and deleteCheckpointRefs without changing the underlying Git commands, control flow, or error handling.

Written by Cursor Bugbot for commit 2e848bc. This will update automatically on new commits. Configure here.

…tore.ts

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8daac962-a4d5-4124-916b-bc0b6963905a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/effect-fn-apps-server-src-checkpointing-layers-checkpointstore

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Apr 1, 2026
@juliusmarminge juliusmarminge marked this pull request as ready for review April 1, 2026 15:39
@juliusmarminge juliusmarminge merged commit 15f0be8 into main Apr 1, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/effect-fn-apps-server-src-checkpointing-layers-checkpointstore branch April 1, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant