Assign default capabilities to Codex custom models#1793
Conversation
- Use a shared Codex capability baseline for unknown models - Include those capabilities in provider snapshots
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Small, well-scoped change by the code owner that assigns default capabilities to custom Codex models. The behavioral change is intentional and explicitly stated in the title - custom models now get the same capability options as built-in models rather than null capabilities. You can customize Macroscope's approvability policy. Learn more. |
Summary
Testing
bun fmt,bun lint,bun typecheck, andbun run test.Note
Low Risk
Low risk: changes only model metadata used for capability/UI selection, with no impact to auth or external API calls.
Overview
Custom models for
codex(and nowclaudeAgent) are no longer created withcapabilities: null;providerModelsFromSettingsnow requires a defaultModelCapabilitiesand assigns it to all custom model entries.Both providers add a shared default capabilities constant and use it consistently when (1) building the provider model list from settings and (2) falling back in
get*ModelCapabilitieswhen a slug isn’t a built-in model, so custom/unknown models get a populated capability shape (Codex includes reasoning effort levels + fast mode by default).Reviewed by Cursor Bugbot for commit dc2058e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Assign default capabilities to Codex and Claude custom models
providerModelsFromSettingspreviously hadnullcapabilities; they now receive a provider-specific defaultModelCapabilitiesobject.DEFAULT_CODEX_MODEL_CAPABILITIESincludes reasoning effort levels (xhigh,highas default,medium,low) andsupportsFastMode: true;DEFAULT_CLAUDE_MODEL_CAPABILITIEShas empty effort levels and both fast mode flags set tofalse.getCodexModelCapabilitiesandgetClaudeModelCapabilitiesalso use these constants as the fallback when a slug doesn't match a built-in model.Macroscope summarized dc2058e.