Skip to content

Assign default capabilities to Codex custom models#1793

Merged
juliusmarminge merged 2 commits intomainfrom
feature/codex-default-capabilities
Apr 6, 2026
Merged

Assign default capabilities to Codex custom models#1793
juliusmarminge merged 2 commits intomainfrom
feature/codex-default-capabilities

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 6, 2026

Summary

  • Assigns a default Codex capability set to custom models instead of leaving them uncategorized.
  • Reuses the same default capability metadata when resolving provider models from settings and when looking up Codex model capabilities.
  • Keeps Codex custom models aligned with the built-in capability shape, including reasoning effort options and fast mode support.

Testing

  • Not run (PR content generation only).
  • Expected checks for the change: bun fmt, bun lint, bun typecheck, and bun run test.

Note

Low Risk
Low risk: changes only model metadata used for capability/UI selection, with no impact to auth or external API calls.

Overview
Custom models for codex (and now claudeAgent) are no longer created with capabilities: null; providerModelsFromSettings now requires a default ModelCapabilities and assigns it to all custom model entries.

Both providers add a shared default capabilities constant and use it consistently when (1) building the provider model list from settings and (2) falling back in get*ModelCapabilities when a slug isn’t a built-in model, so custom/unknown models get a populated capability shape (Codex includes reasoning effort levels + fast mode by default).

Reviewed by Cursor Bugbot for commit dc2058e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Assign default capabilities to Codex and Claude custom models

  • Custom models registered via providerModelsFromSettings previously had null capabilities; they now receive a provider-specific default ModelCapabilities object.
  • DEFAULT_CODEX_MODEL_CAPABILITIES includes reasoning effort levels (xhigh, high as default, medium, low) and supportsFastMode: true; DEFAULT_CLAUDE_MODEL_CAPABILITIES has empty effort levels and both fast mode flags set to false.
  • Both getCodexModelCapabilities and getClaudeModelCapabilities also use these constants as the fallback when a slug doesn't match a built-in model.
  • Behavioral Change: custom Codex models now expose reasoning effort controls and fast mode where they previously had no capabilities.

Macroscope summarized dc2058e.

- Use a shared Codex capability baseline for unknown models
- Include those capabilities in provider snapshots
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 23c17d5d-7aa2-4326-b1dc-499009112043

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/codex-default-capabilities

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 6, 2026

Approvability

Verdict: Approved

Small, well-scoped change by the code owner that assigns default capabilities to custom Codex models. The behavioral change is intentional and explicitly stated in the title - custom models now get the same capability options as built-in models rather than null capabilities.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 226ed99 into main Apr 6, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/codex-default-capabilities branch April 6, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant