Skip to content

[codex] Refresh grouped sidebar refs when membership changes#1837

Merged
juliusmarminge merged 1 commit intot3code/remote-auth-pairingfrom
fix/review-sidebar-member-refs
Apr 8, 2026
Merged

[codex] Refresh grouped sidebar refs when membership changes#1837
juliusmarminge merged 1 commit intot3code/remote-auth-pairingfrom
fix/review-sidebar-member-refs

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 8, 2026

What changed

  • make the grouped-project thread memo depend on project.memberProjectRefs
  • drop the stale eslint suppression and the unnecessary project.projectKey dependency

Why

Grouped sidebar projects were memoizing the list of member refs without depending on the member-ref list itself, so newly connected matching environments could be omitted until an unrelated prop changed.

Validation

  • bun fmt
  • bun lint
  • bun typecheck

Note

Fix grouped sidebar refs to recompute when project membership changes

Fixes the useMemo dependency array for otherMemberRefs in SidebarProjectItem to depend on project.memberProjectRefs instead of project.projectKey, so derived member thread selectors update correctly when membership changes.

Macroscope summarized 021b855.


Note

Low Risk
Low risk: adjusts a useMemo dependency array in the sidebar so derived thread lists update when grouped project membership changes, without altering data models or API behavior.

Overview
Fixes grouped-project sidebar thread aggregation to recompute when membership changes by making otherMemberRefs depend on project.memberProjectRefs (and removing the stale exhaustive-deps eslint suppression / unnecessary project.projectKey dependency). This prevents newly added grouped project refs from being omitted until unrelated project fields change.

Reviewed by Cursor Bugbot for commit 021b855. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 27c6c265-2f8c-4576-845f-c80dffa0e084

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/review-sidebar-member-refs

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 8, 2026
@juliusmarminge juliusmarminge force-pushed the fix/review-sidebar-member-refs branch from 4291481 to 51d1b22 Compare April 8, 2026 21:13
@juliusmarminge juliusmarminge force-pushed the fix/review-sidebar-member-refs branch from 51d1b22 to 021b855 Compare April 8, 2026 21:46
@juliusmarminge juliusmarminge marked this pull request as ready for review April 8, 2026 21:49
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 8, 2026

Approvability

Verdict: Approved

A simple React dependency array bug fix that corrects a stale dependency (project.projectKeyproject.memberProjectRefs) and removes the associated eslint-disable comment. The author wrote the original code and is fixing their own oversight.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit ad9c74b into t3code/remote-auth-pairing Apr 8, 2026
16 of 17 checks passed
@juliusmarminge juliusmarminge deleted the fix/review-sidebar-member-refs branch April 8, 2026 21:57
juliusmarminge added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: Julius Marminge <julius@macmini.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant