[codex] Refresh grouped sidebar refs when membership changes#1837
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
4291481 to
51d1b22
Compare
51d1b22 to
021b855
Compare
ApprovabilityVerdict: Approved A simple React dependency array bug fix that corrects a stale dependency ( You can customize Macroscope's approvability policy. Learn more. |
ad9c74b
into
t3code/remote-auth-pairing
Co-authored-by: Julius Marminge <julius@macmini.local>
What changed
project.memberProjectRefsproject.projectKeydependencyWhy
Grouped sidebar projects were memoizing the list of member refs without depending on the member-ref list itself, so newly connected matching environments could be omitted until an unrelated prop changed.
Validation
bun fmtbun lintbun typecheckNote
Fix grouped sidebar refs to recompute when project membership changes
Fixes the
useMemodependency array forotherMemberRefsinSidebarProjectItemto depend onproject.memberProjectRefsinstead ofproject.projectKey, so derived member thread selectors update correctly when membership changes.Macroscope summarized 021b855.
Note
Low Risk
Low risk: adjusts a
useMemodependency array in the sidebar so derived thread lists update when grouped project membership changes, without altering data models or API behavior.Overview
Fixes grouped-project sidebar thread aggregation to recompute when membership changes by making
otherMemberRefsdepend onproject.memberProjectRefs(and removing the staleexhaustive-depseslint suppression / unnecessaryproject.projectKeydependency). This prevents newly added grouped project refs from being omitted until unrelated project fields change.Reviewed by Cursor Bugbot for commit 021b855. Bugbot is set up for automated code reviews on this repo. Configure here.