Fix server publish check for bin entrypoint#1885
Conversation
- Verify `dist/bin.mjs` instead of the old `dist/index.mjs` - Keep client asset validation unchanged
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Single-line fix to a publish script that corrects a file path check from You can customize Macroscope's approvability policy. Learn more. |
Summary
dist/bin.mjsinstead of the olddist/index.mjspath.dist/client/index.html.Testing
Note
Low Risk
Low risk: only updates a pre-publish build-asset existence check to match the current server entrypoint filename; no runtime logic changes.
Overview
Fixes the server publish CLI’s build-asset validation to require
dist/bin.mjsinstead of the olddist/index.mjs, while keeping the client check fordist/client/index.htmlunchanged.Reviewed by Cursor Bugbot for commit 856a854. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix publish check to verify
dist/bin.mjsinstead ofdist/index.mjsUpdates the pre-publish asset assertion in cli.ts to check for
dist/bin.mjsrather thandist/index.mjs, matching the actual server build output filename.Macroscope summarized 856a854.