Skip to content

Fix server publish check for bin entrypoint#1885

Merged
juliusmarminge merged 1 commit intomainfrom
feature/fix/publish-bin-entrypoint
Apr 10, 2026
Merged

Fix server publish check for bin entrypoint#1885
juliusmarminge merged 1 commit intomainfrom
feature/fix/publish-bin-entrypoint

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 10, 2026

Summary

  • Update the publish-time asset check to validate dist/bin.mjs instead of the old dist/index.mjs path.
  • Keep the existing client asset validation for dist/client/index.html.

Testing

  • Not run (change only updates a publish path check).
  • Lint/typecheck not run in this turn.

Note

Low Risk
Low risk: only updates a pre-publish build-asset existence check to match the current server entrypoint filename; no runtime logic changes.

Overview
Fixes the server publish CLI’s build-asset validation to require dist/bin.mjs instead of the old dist/index.mjs, while keeping the client check for dist/client/index.html unchanged.

Reviewed by Cursor Bugbot for commit 856a854. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix publish check to verify dist/bin.mjs instead of dist/index.mjs

Updates the pre-publish asset assertion in cli.ts to check for dist/bin.mjs rather than dist/index.mjs, matching the actual server build output filename.

Macroscope summarized 856a854.

- Verify `dist/bin.mjs` instead of the old `dist/index.mjs`
- Keep client asset validation unchanged
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bf33bed6-28f9-4351-8778-6e6869859d15

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/fix/publish-bin-entrypoint

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliusmarminge juliusmarminge enabled auto-merge (squash) April 10, 2026 16:44
@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 10, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 10, 2026

Approvability

Verdict: Approved

Single-line fix to a publish script that corrects a file path check from dist/index.mjs to dist/bin.mjs. This is a low-risk build tooling fix with no runtime application impact.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 2028d57 into main Apr 10, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/fix/publish-bin-entrypoint branch April 10, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant