Skip to content

Add terminal Nerd Font fallbacks #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Specter242 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

Add terminal Nerd Font fallbacks #1919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion apps/web/src/components/ThreadTerminalDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ import { selectTerminalEventEntries, useTerminalStateStore } from "../terminalSt
const MIN_DRAWER_HEIGHT = 180;
const MAX_DRAWER_HEIGHT_RATIO = 0.75;
const MULTI_CLICK_SELECTION_ACTION_DELAY_MS = 260;
const TERMINAL_FONT_FAMILY = [
'"SF Mono"',
'"SFMono-Regular"',
"Consolas",
'"Liberation Mono"',
"Menlo",
// Keep the default terminal fonts first; Nerd Font fallbacks cover prompt glyphs when available.
'"MesloLGS NF"',
'"JetBrainsMono Nerd Font Mono"',
'"JetBrainsMono NF"',
"monospace",
].join(", ");

function maxDrawerHeight(): number {
if (typeof window === "undefined") return DEFAULT_THREAD_TERMINAL_HEIGHT;
Expand Down Expand Up @@ -303,7 +315,7 @@ export function TerminalViewport({
lineHeight: 1.2,
fontSize: 12,
scrollback: 5_000,
fontFamily: '"SF Mono", "SFMono-Regular", Consolas, "Liberation Mono", Menlo, monospace',
fontFamily: TERMINAL_FONT_FAMILY,
theme: terminalThemeFromApp(mount),
});
terminal.loadAddon(fitAddon);
Expand Down
Loading