[codex] Fix Windows release manifest publishing#2095
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: codex <codex@users.noreply.github.com>
b2cd97b to
b3a16f5
Compare
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
ApprovabilityVerdict: Approved This is a minor CI/CD fix that adds a 4-line condition to skip debug builder files during Windows release manifest processing. The bulk of the diff is new smoke test code validating this behavior. No runtime application behavior is affected. You can customize Macroscope's approvability policy. Learn more. |
Summary
Fix the Windows release publish step so it only merges real updater manifests, and keep the new Windows ARM release support plus release smoke coverage in place.
Root cause
The release workflow iterated over
release-assets/*-win-x64.yml, which matched both updater manifests likelatest-win-x64.ymland Electron Builder debug files likebuilder-debug-win-x64.yml. The merge step then tried to parse the debug YAML as an updater manifest and failed on the top-levelarm64:key.What changed
mainscripts/lib/update-manifest.tspath with platform-aware merge testslatest*-win-x64.ymlscripts/release-smoke.tsto simulate a mixedrelease-assetsdirectory and verify that builder debug YAML is ignored while updater manifests are merged intolatest.ymlImpact
Validation
bun run test --filter=@t3tools/scriptsbun run release:smokebun fmtbun lintbun typecheckbun lintstill reports existing warnings in unrelated web files, but it exits successfully.Note
Fix Windows release manifest publishing to skip builder-debug manifests
builder-debug-*files when iteratingrelease-assets/*-win-x64.yml, preventing failed merges for debug manifests.scripts/release-smoke.tsis reworked to validate multi-channel manifest merging (latest, nightly, preview), confirm removal of per-arch input files after merging, and assert thatbuilder-debug-*manifests are ignored and preserved.assertExistsandassertMissingprovide fast-fail checks in the smoke test for expected and unexpected files.Macroscope summarized 98ef886.
Note
Medium Risk
Touches release automation and manifest merging behavior; a mistake could break Windows release publishing or produce incorrect updater manifests, but changes are small and smoke-tested.
Overview
Fixes the GitHub Release workflow’s Windows manifest merge so it skips Electron Builder
builder-debug-*YAML files when scanning*-win-x64.yml, preventing the updater manifest merge step from trying to parse non-updater YAML.Expands
scripts/release-smoke.tsto generate channel-specific Windows updater manifests (e.g.latest,nightly,preview), addbuilder-debugfixtures, and assert that only updater manifests are merged into per-channel*.ymloutputs, input per-arch manifests are deleted, and debug fixtures remain untouched.Reviewed by Cursor Bugbot for commit 98ef886. Bugbot is set up for automated code reviews on this repo. Configure here.