Skip to content

ci(release): install deps before finalize version bump#2100

Merged
juliusmarminge merged 1 commit intomainfrom
fix/release-finalize-install-deps
Apr 17, 2026
Merged

ci(release): install deps before finalize version bump#2100
juliusmarminge merged 1 commit intomainfrom
fix/release-finalize-install-deps

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 17, 2026

Summary

The Finalize release job in .github/workflows/release.yml failed on the latest stable release (run #24543937441) with:

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@t3tools/shared' imported from /home/runner/work/t3code/t3code/scripts/update-release-package-versions.ts

scripts/update-release-package-versions.ts imports @t3tools/shared/cliArgs (a workspace package), but the finalize job only set up Bun and Node — it never ran bun install, so the workspace symlink in node_modules did not exist and Node 24's native TS loader failed module resolution.

This adds the missing bun install --frozen-lockfile step before Update version strings, matching the pattern already used by preflight, build, and publish_cli in the same workflow.

Test plan

  • Re-run the failed release workflow (or wait for the next stable tag) and confirm the Finalize release job passes the Update version strings step.

Made with Cursor


Note

Low Risk
Low risk: adds a missing bun install --frozen-lockfile step to the CI workflow, affecting only the release pipeline execution order.

Overview
Fixes the Finalize release GitHub Actions job by installing dependencies before running scripts/update-release-package-versions.ts, ensuring workspace packages resolve correctly.

This inserts bun install --frozen-lockfile after Node/Bun setup and before the version update/format/commit steps, aligning finalize with the other release jobs.

Reviewed by Cursor Bugbot for commit 1c3208d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Install dependencies before version bump step in release preflight job

Adds a bun install --frozen-lockfile step to the preflight job in release.yml before the version bump finalization runs. This fixes a missing dependency setup that caused the subsequent step to fail.

Macroscope summarized 1c3208d.

The finalize job runs scripts/update-release-package-versions.ts, which
imports the workspace package @t3tools/shared. Without bun install,
node_modules has no symlink for that package and Node 24 fails with
ERR_MODULE_NOT_FOUND. Install dependencies before the script runs, in
line with the other jobs in this workflow.

Made-with: Cursor
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b29703c7-a0d9-4895-8e95-1e3aff6ee599

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-finalize-install-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Apr 17, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 17, 2026 02:41
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 17, 2026

Approvability

Verdict: Approved

This is a minor CI/CD fix that adds a missing dependency installation step to the release workflow. The change has no production runtime impact and the author is the primary maintainer of this workflow file.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge disabled auto-merge April 17, 2026 02:42
@juliusmarminge juliusmarminge merged commit b2cca67 into main Apr 17, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the fix/release-finalize-install-deps branch April 17, 2026 02:42
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant