ci(release): install deps before finalize version bump#2100
ci(release): install deps before finalize version bump#2100juliusmarminge merged 1 commit intomainfrom
Conversation
The finalize job runs scripts/update-release-package-versions.ts, which imports the workspace package @t3tools/shared. Without bun install, node_modules has no symlink for that package and Node 24 fails with ERR_MODULE_NOT_FOUND. Install dependencies before the script runs, in line with the other jobs in this workflow. Made-with: Cursor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This is a minor CI/CD fix that adds a missing dependency installation step to the release workflow. The change has no production runtime impact and the author is the primary maintainer of this workflow file. You can customize Macroscope's approvability policy. Learn more. |
Summary
The
Finalize releasejob in.github/workflows/release.ymlfailed on the latest stable release (run #24543937441) with:scripts/update-release-package-versions.tsimports@t3tools/shared/cliArgs(a workspace package), but thefinalizejob only set up Bun and Node — it never ranbun install, so the workspace symlink innode_modulesdid not exist and Node 24's native TS loader failed module resolution.This adds the missing
bun install --frozen-lockfilestep beforeUpdate version strings, matching the pattern already used bypreflight,build, andpublish_cliin the same workflow.Test plan
Finalize releasejob passes theUpdate version stringsstep.Made with Cursor
Note
Low Risk
Low risk: adds a missing
bun install --frozen-lockfilestep to the CI workflow, affecting only the release pipeline execution order.Overview
Fixes the
Finalize releaseGitHub Actions job by installing dependencies before runningscripts/update-release-package-versions.ts, ensuring workspace packages resolve correctly.This inserts
bun install --frozen-lockfileafter Node/Bun setup and before the version update/format/commit steps, aligningfinalizewith the other release jobs.Reviewed by Cursor Bugbot for commit 1c3208d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Install dependencies before version bump step in release preflight job
Adds a
bun install --frozen-lockfilestep to the preflight job in release.yml before the version bump finalization runs. This fixes a missing dependency setup that caused the subsequent step to fail.Macroscope summarized 1c3208d.