Skip to content

try out blacksmith for releases#2101

Merged
juliusmarminge merged 3 commits intomainfrom
more-blacksmith-runners
Apr 17, 2026
Merged

try out blacksmith for releases#2101
juliusmarminge merged 3 commits intomainfrom
more-blacksmith-runners

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 17, 2026

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Workflow-only changes, but they affect CI and the release build/publish pipeline; misconfigured runner images or disabled Windows arm64/manifest steps could break releases or artifact packaging.

Overview
Moves CI quality and release_smoke jobs, plus all release.yml jobs, from GitHub-hosted runners to Blacksmith runner images with increased CPU sizing.

Updates the release build matrix to use Blacksmith runners for macOS/Linux/Windows builds, and comments out the Windows arm64 build as well as the Windows updater-manifest renaming/merge steps (left as opt-in if arm64 builds are re-enabled).

Reviewed by Cursor Bugbot for commit 35af9a9. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Switch release and CI workflow jobs to Blacksmith runners

  • Migrates all Ubuntu jobs in ci.yml and release.yml from standard GitHub-hosted runners to blacksmith-8vcpu-ubuntu-2404 and blacksmith-32vcpu-ubuntu-2404.
  • Updates macOS build runners from macos-14/macos-15-intel to blacksmith-12vcpu-macos-26, and Windows x64 from windows-2022 to blacksmith-32vcpu-windows-2025.
  • Disables the Windows arm64 build matrix entry and comments out per-arch Windows updater manifest renaming and merging steps.
  • Behavioral Change: Windows arm64 releases are no longer built, and Windows updater manifest handling is disabled for this run.

Macroscope summarized 35af9a9.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b1366d05-8d61-4374-991b-7a0d38246a78

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch more-blacksmith-runners

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Apr 17, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: macOS runner instance type may not exist
    • Changed blacksmith-12vcpu-macos-26 to blacksmith-6vcpu-macos-26 since Blacksmith only offers 6vCPU macOS runners.

Create PR

Or push these changes by commenting:

@cursor push f0dec8145f
Preview (f0dec8145f)
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -141,7 +141,7 @@
       matrix:
         include:
           - label: macOS arm64
-            runner: blacksmith-12vcpu-macos-26
+            runner: blacksmith-6vcpu-macos-26
             platform: mac
             target: dmg
             arch: arm64

You can send follow-ups to the cloud agent here.

include:
- label: macOS arm64
runner: macos-14
runner: blacksmith-12vcpu-macos-26
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS runner instance type may not exist

Medium Severity

The macOS arm64 build runner is set to blacksmith-12vcpu-macos-26, but Blacksmith's documented macOS runners only come in 6vCPU configurations (blacksmith-6vcpu-macos-*). If this instance type doesn't exist, the macOS arm64 build job will fail, blocking the entire release pipeline since publish_cli, release, and finalize all depend on the build job completing.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ea67a3f. Configure here.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 17, 2026

Approvability

Verdict: Needs human review

This PR modifies release pipeline infrastructure by switching to Blacksmith runners and disabling Windows arm64 builds. Open review comments identify potential issues with macOS runner configurations that could break the release pipeline - specifically, the specified runner instance types may not exist and cross-compilation concerns for x64 builds on ARM runners.

You can customize Macroscope's approvability policy. Learn more.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Apr 17, 2026
@juliusmarminge juliusmarminge merged commit 505db9f into main Apr 17, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the more-blacksmith-runners branch April 17, 2026 03:12
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 35af9a9. Configure here.

arch: arm64
- label: macOS x64
runner: macos-15-intel
runner: blacksmith-12vcpu-macos-26
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macOS x64 build moved to ARM-only runner

Medium Severity

The macOS x64 build now uses the same ARM-based blacksmith-12vcpu-macos-26 runner as the arm64 build, replacing the former Intel-native macos-15-intel runner. This means x64 artifacts are now cross-compiled from ARM64. The project depends on node-pty, a native C++ module, and electron-builder has documented issues cross-compiling native modules across macOS architectures (linker errors, wrong-arch binaries). The previous config deliberately used an Intel runner for x64 builds.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 35af9a9. Configure here.

znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant