Preserve provider bindings when stopping sessions by HaukeSchnau · Pull Request #2125 · pingdotgg/t3code

HaukeSchnau · 2026-04-17T14:28:13Z

Summary

preserve provider bindings when the idle session reaper stops a session
keep explicit stop-session behavior destructive so manual stop still detaches the provider thread
add coverage for preserved-binding recovery and the reaper stop payload

Why

Idle reaping currently uses the same destructive stop path as an explicit manual stop. For the Codex provider, that drops the resume cursor and forces the next turn onto a fresh Codex thread instead of resuming the previous provider thread.

This change keeps the resume binding for idle cleanup only, so a later send can recover the same provider thread while leaving explicit stop semantics unchanged.

Verification

bun fmt
bun x vitest run apps/server/src/provider/Layers/ProviderService.test.ts apps/server/src/provider/Layers/ProviderSessionReaper.test.ts
bun lint
bun typecheck
manual end-to-end validation against a real T3 + Codex flow, verifying that a thread still resumes after the idle reaper stops the provider session

Notes

callback state for old approvals or user-input requests is still not resumable; this only preserves the provider resume handle across idle cleanup
bun lint passes with existing repo warnings outside this patch

Note

Medium Risk
Changes provider session lifecycle/persistence semantics (stop no longer unbinds), which can affect routing and recovery paths across providers and restarts; coverage is improved but behavior changes are system-wide.

Overview
Provider session stopping is changed from a destructive unbind to a soft stop: ProviderServiceLive.stopSession now upserts the thread binding with status: "stopped" (and clears activeTurnId) instead of deleting it, keeping the persisted provider + resume cursor so a later sendTurn can recover/resume the same provider thread.

ProviderSessionDirectory removes the remove(threadId) API entirely, and tests are updated/added to verify stopped bindings remain persisted and that routing can resume after a stop. ProviderCommandReactor session restart logic is tightened to always prefer the thread-bound provider and to only drop resumeCursor on model-change restarts, with test reordering/adjustments around restart-failure and provider-switch rejection.

^{Reviewed by Cursor Bugbot for commit b33fd1f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Preserve provider bindings when stopping sessions instead of deleting them

ProviderSessionDirectory removes the remove method; stopped sessions are now persisted with status: 'stopped' and activeTurnId: null rather than deleted from the directory.
ProviderService.stopSession upserts the binding on stop, so a subsequent sendTurn can resume from the correct resumeCursor and provider without re-binding from scratch.
ProviderCommandReactor no longer restarts a session solely due to a provider change; it always uses the thread's bound provider and preserves resumeCursor unless a runtime mode or model-change condition requires a restart.
Behavioral Change: Sessions that were previously cleaned up on stop are now retained in persistence; any code path that relied on a missing binding after stop will behave differently.

^{Macroscope summarized b33fd1f.}

coderabbitai · 2026-04-17T14:28:22Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 94b6f852-fad1-407c-bfd7-4748337e9e61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 560da15384

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-17T14:34:55Z

+        const reaped = yield* providerService
+          .stopSession({
+            threadId: binding.threadId,
+            preserveBinding: true,


Clear preserved binding when explicit stop is requested

Calling providerService.stopSession with preserveBinding: true during idle reaping leaves a persisted resume binding even after the runtime session is closed, but processSessionStopRequested only performs a destructive provider stop when thread.session.status !== "stopped" (apps/server/src/orchestration/Layers/ProviderCommandReactor.ts:714-716). In the common reaped state (session already marked stopped), an explicit thread.session.stop command no longer removes that binding, so a later turn can still resume via the persisted cursor (ProviderService.startSession reuses persisted binding state). This makes explicit stop non-destructive for already-reaped threads and breaks the stated manual-stop semantics for that scenario.

Useful? React with 👍 / 👎.

macroscopeapp · 2026-04-17T14:48:45Z

Approvability

Verdict: Needs human review

This PR changes session lifecycle behavior by removing the ability to delete provider bindings on stop. Two unresolved review comments identify that the implementation contradicts the stated intent - manual stops now preserve bindings when they should be destructive, allowing unintended session resumption.

^{You can customize Macroscope's approvability policy. Learn more.}

juliusmarminge · 2026-04-17T16:30:44Z

reading this now i don't remember why we ever remove the provider binding 🤔

- Keep persisted provider bindings on stop/reap - Remove obsolete `preserveBinding` stop flag Co-authored-by: codex <codex@users.noreply.github.com>

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 938a082. Configure here.}

cursor · 2026-04-17T17:48:20Z

+          runtimePayload: {
+            activeTurnId: null,
+          },
+        });


Manual stop preserves binding, contradicting stated destructive intent

High Severity

stopSession now always upserts the binding with status: "stopped", but the PR intent is to only preserve bindings for idle-reaper stops while keeping manual/explicit stops destructive. The preserveBinding conditional mentioned in the PR description was never implemented — ProviderStopSessionInput still only has threadId, and the remove method was completely deleted from ProviderSessionDirectory. After a manual stop, the next sendTurn will recover the same provider thread via the persisted resumeCursor instead of starting fresh.

Additional Locations (1)

apps/server/src/provider/Services/ProviderSessionDirectory.ts#L47-L56

^{Reviewed by Cursor Bugbot for commit 938a082. Configure here.}

- Keep an existing thread bound to its provider after reap - Add regression coverage for first-turn and post-bind provider changes

The `remove` method was removed from `ProviderSessionDirectoryShape` in pingdotgg#2125 (Preserve provider bindings when stopping sessions). The test mock still referenced it, causing a typecheck failure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Preserve provider bindings when idle reaping sessions

560da15

github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 17, 2026

chatgpt-codex-connector bot reviewed Apr 17, 2026

View reviewed changes

Preserve provider binding when stopping sessions

938a082

- Keep persisted provider bindings on stop/reap - Remove obsolete `preserveBinding` stop flag Co-authored-by: codex <codex@users.noreply.github.com>

github-actions bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Apr 17, 2026

cursor bot reviewed Apr 17, 2026

View reviewed changes

juliusmarminge changed the title ~~Preserve provider bindings when idle-reaping sessions~~ Preserve provider bindings when stopping sessions Apr 17, 2026

Reject provider switches on bound threads

b33fd1f

- Keep an existing thread bound to its provider after reap - Add regression coverage for first-turn and post-bind provider changes

juliusmarminge merged commit 721b6b4 into pingdotgg:main Apr 17, 2026
12 checks passed

roni-estein added a commit to roni-estein/t3code that referenced this pull request Apr 17, 2026

Local: apply PR pingdotgg#2125

cc04ee0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve provider bindings when stopping sessions#2125

Preserve provider bindings when stopping sessions#2125
juliusmarminge merged 3 commits intopingdotgg:mainfrom
HaukeSchnau:codex/preserve-codex-binding-on-reap

HaukeSchnau commented Apr 17, 2026 •

edited by macroscopeapp bot

Loading

Uh oh!

coderabbitai bot commented Apr 17, 2026 •

edited

Loading

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 17, 2026

Uh oh!

macroscopeapp bot commented Apr 17, 2026 •

edited

Loading

Uh oh!

juliusmarminge commented Apr 17, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

HaukeSchnau commented Apr 17, 2026 • edited by macroscopeapp bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Verification

Notes

Preserve provider bindings when stopping sessions instead of deleting them

Uh oh!

coderabbitai bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeapp bot commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

juliusmarminge commented Apr 17, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Apr 17, 2026

Choose a reason for hiding this comment

Manual stop preserves binding, contradicting stated destructive intent

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HaukeSchnau commented Apr 17, 2026 •

edited by macroscopeapp bot

Loading

coderabbitai bot commented Apr 17, 2026 •

edited

Loading

macroscopeapp bot commented Apr 17, 2026 •

edited

Loading