Skip to content

Modernize release workflow runners #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 4 commits into from
Apr 17, 2026
+27 −2
Merged

Modernize release workflow runners #2129

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5171383
Modernize release workflow runners
juliusmarminge Apr 17, 2026
926d98b
pwsh
juliusmarminge Apr 17, 2026
40ed71f
Fix Windows release workflow line continuation
juliusmarminge Apr 17, 2026
ba2c1cb
fix: check installer exit code in Spectre-mitigated MSVC libs step
cursoragent Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ jobs:
target: AppImage
arch: x64
- label: Windows x64
runner: windows-2022 # blacksmith-32vcpu-windows-2025
runner: blacksmith-32vcpu-windows-2025
platform: win
target: nsis
arch: x64
Expand Down Expand Up @@ -188,6 +188,23 @@ jobs:
- name: Align package versions to release version
run: node scripts/update-release-package-versions.ts "${{ needs.preflight.outputs.version }}"

- name: Install Spectre-mitigated MSVC libs
Comment thread
macroscopeapp[bot] marked this conversation as resolved.
if: matrix.platform == 'win'
shell: pwsh
run: |
$vswhere = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\vswhere.exe"
$installPath = & $vswhere -products * -latest -property installationPath
$setupExe = "${env:ProgramFiles(x86)}\Microsoft Visual Studio\Installer\setup.exe"
$proc = Start-Process -FilePath $setupExe `
-ArgumentList "modify", "--installPath", "`"$installPath`"", "--add", `
"Microsoft.VisualStudio.Component.VC.Tools.x86.x64.Spectre", "--quiet", "--norestart" `
-Wait -PassThru -NoNewWindow
Comment thread
cursor[bot] marked this conversation as resolved.
if ($null -eq $proc -or $proc.ExitCode -ne 0) {
$code = if ($null -ne $proc) { $proc.ExitCode } else { 1 }
Write-Error "Visual Studio Installer failed with exit code $code"
exit $code
}
Copy link
Copy Markdown
Contributor

@cursor cursor bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation in PowerShell script block

Low Severity

The first content line of the YAML | block scalar ($vswhere = ...) is at 10 spaces indentation, but all subsequent lines ($installPath, $setupExe, $proc, if, etc.) are at 13 spaces. YAML auto-detects the indentation level from the first content line, so the resulting PowerShell script has 0 leading spaces on the first statement and 3 extra leading spaces on every other statement. PowerShell is whitespace-insensitive so this runs correctly, but it's clearly an accidental paste artifact that makes the script harder to read.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ba2c1cb. Configure here.


- name: Build desktop artifact
shell: bash
env:
Expand Down Expand Up @@ -333,19 +350,27 @@ jobs:
release:
name: Publish GitHub Release
needs: [preflight, build, publish_cli]
runs-on: blacksmith-8vcpu-ubuntu-2404
runs-on: ubuntu-24.04 # blacksmith-8vcpu-ubuntu-2404
timeout-minutes: 10
steps:
- name: Checkout
uses: actions/checkout@v6
with:
ref: ${{ needs.preflight.outputs.ref }}

- name: Setup Bun
uses: oven-sh/setup-bun@v2
with:
bun-version-file: package.json

- name: Setup Node
uses: actions/setup-node@v6
with:
node-version-file: package.json

- name: Install dependencies
run: bun install --frozen-lockfile

- name: Download all desktop artifacts
uses: actions/download-artifact@v8
with:
Expand Down
Loading