Skip to content

Guard release workflow jobs on upstream success#2147

Merged
juliusmarminge merged 1 commit intomainfrom
feature/guard-release-jobs
Apr 17, 2026
Merged

Guard release workflow jobs on upstream success#2147
juliusmarminge merged 1 commit intomainfrom
feature/guard-release-jobs

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 17, 2026

Summary

  • Add explicit job guards to the release workflow so downstream jobs only run when upstream jobs succeed.
  • Prevent build, publish_cli, release, and finalize from continuing after failures or cancellations.
  • Keep the stable-channel finalization step gated behind a successful release.

Testing

  • Not run (workflow-only change).
  • Reviewed .github/workflows/release.yml job conditions for build, publish_cli, release, and finalize.

Note

Low Risk
Low risk workflow-only change, but it can alter release automation behavior by preventing build/publish/release/finalize steps from running after upstream failures or skips.

Overview
Tightens .github/workflows/release.yml job conditions so build, publish_cli, and release only execute when their upstream dependencies completed successfully (in addition to not being cancelled/failing).

Also gates finalize on both a successful preflight and release, while keeping the existing stable-channel only restriction.

Reviewed by Cursor Bugbot for commit 37485cc. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Guard release workflow jobs on explicit upstream job success

The build, publish_cli, release, and finalize jobs in release.yml previously ran whenever the workflow had not failed or been cancelled, even if upstream jobs were skipped. Each job now also requires all upstream jobs to have result == 'success', ensuring the pipeline stops if any earlier step does not complete successfully.

Macroscope summarized 37485cc.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fdf34c36-ac22-4a93-b6c4-291e5a4435e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/guard-release-jobs

Comment @coderabbitai help to get the list of available commands and usage tips.

- Require successful `preflight`, `build`, and publish steps before release jobs run
- Prevent release workflow stages from starting when dependencies fail
@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 17, 2026
@juliusmarminge juliusmarminge force-pushed the feature/guard-release-jobs branch from a374c8f to 37485cc Compare April 17, 2026 23:39
@juliusmarminge juliusmarminge merged commit 8ac57f7 into main Apr 17, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/guard-release-jobs branch April 17, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant