Guard release workflow jobs on upstream success#2147
Merged
juliusmarminge merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
- Require successful `preflight`, `build`, and publish steps before release jobs run - Prevent release workflow stages from starting when dependencies fail
a374c8f to
37485cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build,publish_cli,release, andfinalizefrom continuing after failures or cancellations.Testing
.github/workflows/release.ymljob conditions forbuild,publish_cli,release, andfinalize.Note
Low Risk
Low risk workflow-only change, but it can alter release automation behavior by preventing
build/publish/release/finalize steps from running after upstream failures or skips.Overview
Tightens
.github/workflows/release.ymljob conditions sobuild,publish_cli, andreleaseonly execute when their upstream dependencies completed successfully (in addition to not being cancelled/failing).Also gates
finalizeon both a successfulpreflightandrelease, while keeping the existing stable-channel only restriction.Reviewed by Cursor Bugbot for commit 37485cc. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Guard release workflow jobs on explicit upstream job success
The
build,publish_cli,release, andfinalizejobs in release.yml previously ran whenever the workflow had not failed or been cancelled, even if upstream jobs were skipped. Each job now also requires all upstream jobs to haveresult == 'success', ensuring the pipeline stops if any earlier step does not complete successfully.Macroscope summarized 37485cc.