Skip to content

chore(turbo): pass through PATHEXT#2184

Open
adammansfield wants to merge 1 commit intopingdotgg:mainfrom
adammansfield:chore/pass-through-pathext-in-turbo
Open

chore(turbo): pass through PATHEXT#2184
adammansfield wants to merge 1 commit intopingdotgg:mainfrom
adammansfield:chore/pass-through-pathext-in-turbo

Conversation

@adammansfield
Copy link
Copy Markdown
Contributor

@adammansfield adammansfield commented Apr 18, 2026

What Changed

Add PATHEXT to globalPassThroughEnv in turbo.json.

Why

On Windows with bun dev:desktop or bun start:desktop, Turbo strict mode omits PATHEXT, so terminal-drawer commands cannot resolve executables in PATH without explicit file extensions.

Expected:

echo "$env:PATHEXT"  
# .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL

cd C:\temp
$env:PATH = "C:\temp;$env:PATH"
'@echo hello world' > testshim.cmd  
testshim
# hello world

Actual:
bun dev:desktop
image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes -- no UI changes
  • I included a video for animation/interaction changes -- no animation changes

Validation

  • bun fmt
  • bun lint
  • bun typecheck
  • bun dev:desktop (on Windows)
  • bun start:desktop (on Windows)

After fix:
bun dev:desktop
image


Note

Low Risk
Low risk config-only change that affects how Turborepo forwards environment variables, primarily impacting Windows command resolution.

Overview
Adds PATHEXT to Turborepo’s globalPassThroughEnv in turbo.json, ensuring all tasks inherit this variable from the invoking shell (notably fixing Windows executable resolution in strict env mode).

Reviewed by Cursor Bugbot for commit 2f36b31. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Pass PATHEXT through to all Turborepo tasks via globalPassThroughEnv

Adds PATHEXT to globalPassThroughEnv in turbo.json so all Turborepo tasks inherit the PATHEXT environment variable from the invoking shell. This is primarily relevant on Windows, where PATHEXT controls which file extensions are treated as executable.

Macroscope summarized 2f36b31.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5fb24727-34dd-440b-9e96-5af2d703ee11

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 18, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 18, 2026

Approvability

Verdict: Approved

Single-line Turborepo configuration change that passes through the Windows PATHEXT environment variable for build compatibility. No runtime or production behavior impact.

You can customize Macroscope's approvability policy. Learn more.

On Windows, Turbo strict mode omits PATHEXT, so terminal-drawer commands with `dev:desktop` or `start:desktop` cannot resolve executables without explicit file extensions.
@adammansfield adammansfield force-pushed the chore/pass-through-pathext-in-turbo branch from 1c25204 to 2f36b31 Compare April 18, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant