fix: Change right panel sheet to be below title bar / action bar#2224
fix: Change right panel sheet to be below title bar / action bar#2224juliusmarminge merged 3 commits intopingdotgg:mainfrom
Conversation
- Can now close Tasks when breakpoint below 1180px is activated - Can now close Diff panel when breakpoint below 1180px is activated - Can now drag window around by the title bar without weird gaps that would not register
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Pure CSS class changes to adjust right panel sheet positioning relative to the titlebar area. No runtime behavior changes - only visual layout adjustments using Tailwind window controls overlay (wco:) classes. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 0258929
Upstream additions: - fix(web): restore manual sort drag and keep per-group expand state (pingdotgg#2221) - fix: Change right panel sheet to be below title bar / action bar (pingdotgg#2224) - Refactor OpenCode lifecycle and structured output handling (pingdotgg#2218) - effect-codex-app-server (pingdotgg#1942) - Redesign model picker with favorites and search (pingdotgg#2153) - fix(server): prevent probeClaudeCapabilities from wasting API requests (pingdotgg#2192) - fix(server): handle OpenCode text response format in commit message gen (pingdotgg#2202) - Devcontainer / IDE updates (pingdotgg#2208) - Expand leading ~ in Codex home paths before exporting CODEX_HOME (pingdotgg#2210) - fix(release): use v<semver> tag format for nightly releases (pingdotgg#2186) Fork adaptations: - Took upstream's redesigned model picker with favorites and search - Removed deleted codexAppServerManager (replaced by effect-codex-app-server) - Stubbed fetchCodexUsage (manager-based readout no longer available) - Extended PROVIDER_ICON_BY_PROVIDER for all 8 fork providers - Extended modelOptionsByProvider test fixtures for all 8 providers - Inline ClaudeSlashCommand type (not yet re-exported from SDK) - Updated SettingsPanels imports for new picker module structure - Preserved fork's CI customizations (ubuntu-24.04 not Blacksmith)
Summary
Fix to allow Tasks and Diff right panel sheet to be closed when breakpoint below 1180px is activated.
Problem
When the Tasks right panel switches to sheet mode the button to close the panel displays underneath the window close button stopping the user from clicking it.
A similar problem happens with the Diff panel, the Diff panel's buttons cover the Diff panel toggle from the title bar / action bar stopping the user from closing it.
Another minor problem was when the Task right panel was active and covering the title bar / action bar there were places where the user could click and drag the window and other dead zones that did not allow this behaviour.
What changed
Why
This is a small change with a lot of benefits, it changes the position of the right panel in sheet mode so that the action buttons are always accessible. This will take affect for all future right panels in sheet mode so there are less mistakes in the future. The current approach was hard coding styling to allow for the window buttons on the Diff panel but this did not exist for the Tasks panel. This approach unifies the solution to apply to both and future panels.
UI Changes
Tasks panel Before:

Tasks panel After:

Diff panel Before:

Diff panel After:

Checklist
Note
Low Risk
Low risk: small, CSS-only layout tweaks for Electron window-controls-overlay; main risk is minor regressions in sheet sizing/spacing at the 1180px breakpoint.
Overview
Fixes right-panel sheet mode in Electron window-controls-overlay so it renders below the title bar/action bar, keeping close/toggle controls clickable.
This updates
RIGHT_PANEL_SHEET_CLASS_NAMEto add awco:top offset and corresponding height/max-height adjustments, and tightensDiffPanelShellheader padding so the specialwco:pr[...]compensation only applies when the draggable titlebar region is active.Reviewed by Cursor Bugbot for commit 0258929. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix right panel sheet to render below the title bar in Electron (wco) mode
wco:mt-[env(titlebar-area-height)]and matching height/max-height classes toRIGHT_PANEL_SHEET_CLASS_NAMEin rightPanelLayout.ts so the sheet starts below the titlebar instead of overlapping it.wco:pr-[...]right-padding class ingetDiffPanelHeaderRowClassName(DiffPanelShell.tsx) so it only applies when the Electron drag region is active, not in sheet mode.Macroscope summarized 0258929.