fix(request-permission): add dynamic_tool_call to command request#2311
fix(request-permission): add dynamic_tool_call to command request#2311juliusmarminge merged 2 commits intopingdotgg:mainfrom
dynamic_tool_call to command request#2311Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Single-line addition of a missing switch case, mapping 'dynamic_tool_call' to the 'command' request kind alongside similar existing cases. Minimal, self-contained bug fix with clear intent. You can customize Macroscope's approvability policy. Learn more. |
…ingdotgg#2311) (cherry picked from commit 0ee302e)
What Changed
Claude code MCP tool call requests are never showing the permission prompt UI since they are classified as
dynamic_tool_call. This PR addsdynamic_tool_calltorequestKindFromRequestTypewhich fixes this issue.Why
Threads are stuck in waiting for approval since you cannot accept the tool call you are stuck infinitely.
UI Changes
No UI changes.
Checklist
- [] I included before/after screenshots for any UI changes- [ ] I included a video for animation/interaction changesNote
Low Risk
Low risk: a small mapping change that only affects how pending approval requests are classified and displayed for permission prompts.
Overview
Ensures
dynamic_tool_callrequests are classified ascommandinrequestKindFromRequestType, so these tool-call approvals are surfaced as pending command permissions instead of being treated as unknown/unhandled.Reviewed by Cursor Bugbot for commit f487726. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Map
dynamic_tool_callrequest type tocommandinrequestKindFromRequestTypeIn session-logic.ts, adds
"dynamic_tool_call"as a case inrequestKindFromRequestTypeso it returns"command"instead ofnull. Previously,dynamic_tool_callrequests were not recognized and would have been treated as unknown/unpermissioned.Macroscope summarized f487726.