Skip to content

fix(request-permission): add dynamic_tool_call to command request#2311

Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom
th1m0:fix/request-permission-prompt
Apr 23, 2026
Merged

fix(request-permission): add dynamic_tool_call to command request#2311
juliusmarminge merged 2 commits intopingdotgg:mainfrom
th1m0:fix/request-permission-prompt

Conversation

@th1m0
Copy link
Copy Markdown
Contributor

@th1m0 th1m0 commented Apr 23, 2026

What Changed

Claude code MCP tool call requests are never showing the permission prompt UI since they are classified as dynamic_tool_call. This PR adds dynamic_tool_call to requestKindFromRequestType which fixes this issue.

Why

Threads are stuck in waiting for approval since you cannot accept the tool call you are stuck infinitely.

UI Changes

No UI changes.

Checklist

  • This PR is small and focused
  • I explained what changed and why
    - [] I included before/after screenshots for any UI changes
    - [ ] I included a video for animation/interaction changes

Note

Low Risk
Low risk: a small mapping change that only affects how pending approval requests are classified and displayed for permission prompts.

Overview
Ensures dynamic_tool_call requests are classified as command in requestKindFromRequestType, so these tool-call approvals are surfaced as pending command permissions instead of being treated as unknown/unhandled.

Reviewed by Cursor Bugbot for commit f487726. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Map dynamic_tool_call request type to command in requestKindFromRequestType

In session-logic.ts, adds "dynamic_tool_call" as a case in requestKindFromRequestType so it returns "command" instead of null. Previously, dynamic_tool_call requests were not recognized and would have been treated as unknown/unpermissioned.

Macroscope summarized f487726.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6a03b0d9-4fe2-4384-9f95-93377b5fb71e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 23, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 23, 2026

Approvability

Verdict: Approved

Single-line addition of a missing switch case, mapping 'dynamic_tool_call' to the 'command' request kind alongside similar existing cases. Minimal, self-contained bug fix with clear intent.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge enabled auto-merge (squash) April 23, 2026 15:37
@juliusmarminge juliusmarminge merged commit 0ee302e into pingdotgg:main Apr 23, 2026
10 checks passed
yazandabbas pushed a commit to yazandabbas/Presence that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants