Exclude subscribe RPCs from latency tracking#2313
Conversation
- Treat any RPC tag containing `subscribe` as a subscription - Avoid flagging subscription acknowledgements as slow RPCs
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Single-line change that broadens the exclusion filter for subscribe RPCs in latency tracking. This is a low-risk observability adjustment with clear intent and minimal scope. You can customize Macroscope's approvability policy. Learn more. |
(cherry picked from commit d5b7690)
subscribeas a subscriptionWhat Changed
Why
UI Changes
Checklist
Note
Low Risk
Low risk, single-condition change that only affects which RPCs are included in slow-ack tracking; main risk is over/under-filtering tags that contain the substring
subscribe.Overview
Updates RPC ack latency tracking to treat any tag containing
subscribeas a subscription, not just tags that start with it, preventing subscription acknowledgements from being flagged as slow inrequestLatencyState.ts.Reviewed by Cursor Bugbot for commit d504f89. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
shouldTrackRpcAckto exclude subscribe RPCs with 'subscribe' anywhere in the tagChanges the check in
requestLatencyState.tsfromstartsWith('subscribe')toincludes('subscribe'), so any RPC tag containing 'subscribe' anywhere is excluded from latency tracking, not just those prefixed with it.Macroscope summarized d504f89.