Skip to content

Exclude subscribe RPCs from latency tracking#2313

Merged
juliusmarminge merged 1 commit intomainfrom
feature/exclude-subscribe-rpcs
Apr 23, 2026
Merged

Exclude subscribe RPCs from latency tracking#2313
juliusmarminge merged 1 commit intomainfrom
feature/exclude-subscribe-rpcs

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 23, 2026

  • Treat any RPC tag containing subscribe as a subscription
  • Avoid flagging subscription acknowledgements as slow RPCs

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk, single-condition change that only affects which RPCs are included in slow-ack tracking; main risk is over/under-filtering tags that contain the substring subscribe.

Overview
Updates RPC ack latency tracking to treat any tag containing subscribe as a subscription, not just tags that start with it, preventing subscription acknowledgements from being flagged as slow in requestLatencyState.ts.

Reviewed by Cursor Bugbot for commit d504f89. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix shouldTrackRpcAck to exclude subscribe RPCs with 'subscribe' anywhere in the tag

Changes the check in requestLatencyState.ts from startsWith('subscribe') to includes('subscribe'), so any RPC tag containing 'subscribe' anywhere is excluded from latency tracking, not just those prefixed with it.

Macroscope summarized d504f89.

- Treat any RPC tag containing `subscribe` as a subscription
- Avoid flagging subscription acknowledgements as slow RPCs
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 23, 2026 15:19
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 35f2fe8a-1538-4f9e-a597-df6bcadda880

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/exclude-subscribe-rpcs

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Apr 23, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 23, 2026

Approvability

Verdict: Approved

Single-line change that broadens the exclusion filter for subscribe RPCs in latency tracking. This is a low-risk observability adjustment with clear intent and minimal scope.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit d5b7690 into main Apr 23, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/exclude-subscribe-rpcs branch April 23, 2026 15:24
yazandabbas pushed a commit to yazandabbas/Presence that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant