[codex] fix terminal dimension validation

[juliusmarminge]

Summary

• Raise the terminal dimension contract limits so valid xterm fit results from wide desktop windows are accepted.
• Add a regression test for the reported cols: 423 startup size from issue [Bug]: #2395.

Root Cause

The desktop terminal opens by fitting xterm to the available drawer size and sending the resulting cols/rows to terminal.open. On wide Windows layouts, xterm can validly report more than 400 columns. The shared contract rejected cols: 423, so the server never created the terminal session. Follow-up input/resize calls then targeted a terminal thread that did not exist, producing the repeated Unknown terminal thread errors.

Fixes #2395.

Validation

• bun run test src/terminal.test.ts from packages/contracts
• bun fmt
• bun lint
• bun typecheck
• bun run test

Note

Widen terminal dimension validation bounds in TerminalColsSchema and TerminalRowsSchema

Relaxes the accepted range for terminal dimensions to support ultrawide and non-standard terminal sizes. TerminalColsSchema now accepts 1–1000 (previously 20–400) and TerminalRowsSchema accepts 1–500 (previously 5–200).

^{Macroscope summarized 680951e.}

---

Note

Low Risk
Small contract/test change that only broadens accepted numeric input ranges; low risk aside from potentially allowing unexpectedly large terminal allocations.

Overview
Relaxes terminal dimension validation in the shared contracts so terminal.open and terminal.resize accept much larger xterm fit results (cols 1–1000 vs 20–400, rows 1–500 vs 5–200).

Adds a regression test ensuring an ultrawide 423x40 open payload decodes successfully, and updates the invalid-bounds test to reflect the new minimum row constraint.

^{Reviewed by Cursor Bugbot for commit 680951e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 28079194-c431-4018-a7e4-1a22926b0800

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/terminal-startup-bug

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

Simple validation relaxation to support ultrawide terminal dimensions. The change is permissive and self-contained with no security implications. The low-severity test coverage comment does not indicate a functional issue.

^{You can customize Macroscope's approvability policy. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

• ✅ Fixed: Test no longer validates column bounds rejection
  • Changed cols from 10 (valid under relaxed schema min 1) to 0 (invalid) so the test now validates rejection of both column and row bounds.

Preview

diff --git a/packages/contracts/src/terminal.test.ts b/packages/contracts/src/terminal.test.ts
--- a/packages/contracts/src/terminal.test.ts
+++ b/packages/contracts/src/terminal.test.ts
@@ -54,7 +54,7 @@ describe("TerminalOpenInput", () => {
       decodes(TerminalOpenInput, {
         threadId: "thread-1",
         cwd: "/tmp/project",
-        cols: 10,
+        cols: 0,
         rows: 0,
       }),
     ).toBe(false);

@@ -54,7 +54,7 @@ describe("TerminalOpenInput", () => {
       decodes(TerminalOpenInput, {
         threadId: "thread-1",
         cwd: "/tmp/project",
-        cols: 10,
+        cols: 0,
         rows: 0,
       }),
     ).toBe(false);

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 680951e. Configure here.}