Skip to content

fix(web): make thread archive button always visible on mobile#2423

Merged
juliusmarminge merged 5 commits intopingdotgg:mainfrom
jappyjan:mobile-archive-button-visible
Apr 30, 2026
Merged

fix(web): make thread archive button always visible on mobile#2423
juliusmarminge merged 5 commits intopingdotgg:mainfrom
jappyjan:mobile-archive-button-visible

Conversation

@jappyjan
Copy link
Copy Markdown
Contributor

@jappyjan jappyjan commented Apr 30, 2026

Summary

  • The archive button on each thread row was hidden by default and only revealed on hover/focus, leaving it unreachable on touch devices.
  • Mirrors the new-thread-button mobile fix: add `max-sm:pointer-events-auto max-sm:opacity-100` so the archive button is always visible/interactive on mobile, while preserving the hover/focus reveal on desktop.
  • Also fade out the thread metadata on mobile (`max-sm:opacity-0`) so it doesn't visually overlap the archive button — matching the desktop hover-swap behavior.
  • Both archive button containers are updated: the one used when `confirmThreadArchive` is enabled and the immediate-archive variant.

Test plan

  • On a mobile viewport, the archive icon is visible at the right edge of every non-running thread row.
  • Tapping the icon archives the thread (with confirmation flow if `confirmThreadArchive` is on, immediate otherwise).
  • On desktop, the archive button still appears only on hover/focus, and the metadata (timestamp/jump label) is shown when not hovered.
  • Currently-running threads still show the running indicator instead of the archive button on both mobile and desktop.

🤖 Generated with Claude Code


Open in Devin Review

Note

Low Risk
Primarily Tailwind class tweaks and sidebar/navigation behavior changes; low risk aside from potential minor layout or navigation regressions on small screens.

Overview
Improves mobile sidebar usability. Thread-row archive controls are now always visible and tappable on small viewports (including both confirm-archive and immediate-archive variants), with extra spacing and metadata fade-out to prevent overlap.

Tightens mobile navigation behavior. The sidebar now auto-closes on mobile when navigating to Settings or switching Settings sections, and Settings back/Escape handling now falls back to routing to / when there’s no in-app history instead of calling history.back() unconditionally.

Reviewed by Cursor Bugbot for commit 0eb4d80. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Make thread archive button and sidebar controls always visible on mobile

  • Adjusts SidebarThreadRow to allocate more right-side space on small screens via conditional min-width and padding classes, ensuring the archive button is always visible.
  • Closes the mobile sidebar before navigating to Settings from SidebarChromeFooter and before navigating to a settings section or pressing Back in SettingsSidebarNav.
  • Replaces window.history.back() in the settings Escape key handler with an in-app navigation helper that falls back to the home route when no back history exists.

Macroscope summarized 0eb4d80.

Mirrors the new-thread-button mobile fix: on touch viewports (max-sm) the
archive button cannot be revealed via hover, so make it always visible
and pointer-interactive on mobile while preserving the hover/focus reveal
on desktop. Also fade out the thread metadata on mobile so the metadata
doesn't visually overlap the archive button (matching the desktop hover
swap behavior).

Both archive button containers are updated — the one used when
confirmThreadArchive is enabled and the immediate-archive variant.

Co-Authored-By: Claude Sonnet 4.7 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a60d24e5-f2ce-4d17-9712-7bccd3e98ded

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 30, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 30, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 30, 2026

Approvability

Verdict: Approved

CSS-only changes making mobile UI elements visible and minor UX improvements (closing sidebar on navigation, better back button handling). No business logic or runtime behavior changes beyond expected mobile responsiveness.

You can customize Macroscope's approvability policy. Learn more.

@jappyjan jappyjan marked this pull request as draft April 30, 2026 15:55
@juliusmarminge juliusmarminge marked this pull request as ready for review April 30, 2026 18:18
- Surface the archive action in the mobile sidebar
- Keep settings sidebar navigation aligned with the new button
- Delete local .t33 cache and userdata files
- Stop tracking session state and signing-key artifacts
@macroscopeapp macroscopeapp Bot dismissed their stale review April 30, 2026 18:34

Dismissing prior approval to re-evaluate 2fda5ce

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Apr 30, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fa2dd8b. Configure here.

Comment thread apps/web/src/components/settings/SettingsSidebarNav.tsx Outdated
- Hide the mobile drawer when using the back action
- Preserve existing browser-history and home navigation behavior
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 30, 2026 18:42
@juliusmarminge juliusmarminge merged commit 532a1d8 into pingdotgg:main Apr 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants