Skip to content

Add new GitHub users to VOUCHED.td#2425

Merged
juliusmarminge merged 2 commits intomainfrom
juliusmarminge-patch-1
Apr 30, 2026
Merged

Add new GitHub users to VOUCHED.td#2425
juliusmarminge merged 2 commits intomainfrom
juliusmarminge-patch-1

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 30, 2026

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Open in Devin Review

Note

Low Risk
Low risk change limited to updating the vouch trust list; it only affects who is treated as trusted by the workflow.

Overview
Updates .github/VOUCHED.td by adding three GitHub usernames (jappyjan, justsomelegs, UtkarshUsername) to the repository’s trusted contributor list used by the vouch workflow.

Reviewed by Cursor Bugbot for commit 2e58f06. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add three GitHub users to VOUCHED.td

Adds jappyjan, justsomelegs, and UtkarshUsername to VOUCHED.td.

Macroscope summarized 2e58f06.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cdbabc8c-3c02-4c7e-9bff-ef0e5a060ce0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch juliusmarminge-patch-1

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliusmarminge juliusmarminge enabled auto-merge (squash) April 30, 2026 18:53
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Apr 30, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix prepared fixes for both issues found in the latest run.

  • ✅ Fixed: Undisclosed user added to security trust list
    • Removed github:UtkarshUsername which was added in a second commit but never mentioned in the PR title or description, representing an undisclosed addition to the security trust list.
  • ✅ Fixed: New entries violate alphabetical sorting requirement
    • Sorted all entries in VOUCHED.td alphabetically (case-insensitive) as required by the file's comment on line 11, fixing both the new additions and pre-existing out-of-order entries.

Create PR

Or push these changes by commenting:

@cursor push 4939b15fc0
Preview (4939b15fc0)
diff --git a/.github/VOUCHED.td b/.github/VOUCHED.td
--- a/.github/VOUCHED.td
+++ b/.github/VOUCHED.td
@@ -13,12 +13,15 @@
 github:binbandit
 github:chuks-qua
 github:cursoragent
+github:eggfriedrice24
 github:gbarros-dev
 github:github-actions[bot]
 github:hwanseoc
 github:jamesx0416
+github:jappyjan
 github:jasonLaster
 github:JoeEverest
+github:justsomelegs
 github:maria-rcks
 github:nmggithub
 github:Noojuno
@@ -26,10 +29,6 @@
 github:PatrickBauer
 github:realAhmedRoach
 github:shiroyasha9
+github:shivamhwp
 github:Yash-Singh1
-github:eggfriedrice24
 github:Ymit24
-github:shivamhwp
-github:jappyjan
-github:justsomelegs
-github:UtkarshUsername

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit 2e58f06. Configure here.

Comment thread .github/VOUCHED.td
github:shivamhwp
github:jappyjan
github:justsomelegs
github:UtkarshUsername
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undisclosed user added to security trust list

High Severity

The PR description explicitly states it adds jappyjan and justsomelegs, but github:UtkarshUsername is also added to the trust list without being mentioned anywhere in the PR title or description. Since VOUCHED.td controls which external contributors are treated as trusted by the vouch workflow, an undisclosed addition to this file is a security concern — it could grant trusted CI/workflow status to an unvetted user.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2e58f06. Configure here.

Comment thread .github/VOUCHED.td
github:shivamhwp
github:jappyjan
github:justsomelegs
github:UtkarshUsername
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New entries violate alphabetical sorting requirement

Low Severity

The file comment on line 11 says "Keep entries sorted alphabetically," but the three new entries (jappyjan, justsomelegs, UtkarshUsername) are appended at the end instead of being inserted in their correct alphabetical positions. This makes it harder to spot duplicates and maintain the trust list over time.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2e58f06. Configure here.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Apr 30, 2026

Approvability

Verdict: Needs human review

Changes to VOUCHED.td affect which users are granted trusted CI/workflow status, making this security-sensitive. Additionally, an unresolved high-severity comment notes that one user (UtkarshUsername) was added without being mentioned in the PR description.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit e25ce07 into main Apr 30, 2026
13 checks passed
@juliusmarminge juliusmarminge deleted the juliusmarminge-patch-1 branch April 30, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant