Skip to content

fix version test#2490

Merged
juliusmarminge merged 2 commits intomainfrom
fix-version
May 4, 2026
Merged

fix version test#2490
juliusmarminge merged 2 commits intomainfrom
fix-version

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 4, 2026

What Changed

Why

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: a small branding constant change to use import.meta.env.APP_VERSION plus a UI placeholder tweak; main risk is misconfigured builds/tests if APP_VERSION isn’t set.

Overview
Build/versioning now uses import.meta.env.APP_VERSION (with fallback "0.0.0") instead of a hardcoded APP_VERSION in branding.ts.

In Connections settings, the SSH add-environment form’s username field placeholder changes from "julius" to "root".

Reviewed by Cursor Bugbot for commit 0908f57. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix version test by reading APP_VERSION from environment instead of hardcoding it

  • Replaces the hardcoded "0.0.20" in branding.ts with import.meta.env.APP_VERSION, falling back to "0.0.0" when the env var is absent.
  • Updates the SSH Username placeholder in ConnectionsSettings.tsx from "julius" to "root".

Macroscope summarized 0908f57.

@juliusmarminge juliusmarminge enabled auto-merge (squash) May 4, 2026 05:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d29d934d-7ec3-4727-b527-576661a42be0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-version

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 4, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 4, 2026

Approvability

Verdict: Approved

Simple fix that reverts APP_VERSION to use an environment variable (with fallback) instead of a hardcoded value, plus a minor placeholder text update. Both changes are low-risk and self-contained.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit d501ebe into main May 4, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the fix-version branch May 4, 2026 05:27
Morphexe pushed a commit to Morphexe/t3code that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant