Skip to content

Refresh Codex protocol bindings and adapter mappings#2590

Merged
juliusmarminge merged 1 commit intomainfrom
t3code/ffd5eff9
May 8, 2026
Merged

Refresh Codex protocol bindings and adapter mappings#2590
juliusmarminge merged 1 commit intomainfrom
t3code/ffd5eff9

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 8, 2026

Summary

  • Regenerated the Codex app-server protocol bindings against the newer upstream ref, adding newly exposed requests, responses, and notifications.
  • Updated the server adapter to map realtime start events from the upstream realtimeSessionId field.
  • Expanded provider/runtime typing to accept the newer shared serviceTier schema and added auth labeling for Amazon Bedrock accounts.
  • Added coverage for the new realtime mapping and Bedrock auth status.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Regenerates and expands Codex protocol bindings to a new upstream ref, which can subtly change request/notification shapes consumed across the server. Also tweaks adapter/provider mapping logic (realtime session id + auth labeling), so regressions would show up as missing/incorrect runtime events or status display.

Overview
Refreshes the generated effect-codex-app-server protocol bindings to a newer upstream ref, adding/removing various request/response/notification method constants and schema exports to match the updated Codex app-server protocol.

Fixes Codex realtime start event mapping to use the upstream realtimeSessionId field (instead of sessionId) and adds test coverage for this mapping.

Extends Codex provider status reporting to label amazonBedrock accounts as Amazon Bedrock, with a new registry test to verify the auth label/type, and updates runtime option typing to align serviceTier with the latest shared schema.

Reviewed by Cursor Bugbot for commit 9c6dc73. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Refresh Codex protocol bindings and fix realtimeSessionId mapping in adapter

  • Updates generated schema, namespace, and meta files in effect-codex-app-server to a new upstream protocol reference (07b6951), adding methods like thread/approveGuardianDeniedAction, hooks/list, marketplace/upgrade, and several plugin/process/remoteControl notifications, while removing device/key/* and thread/turns/list.
  • Fixes a bug in CodexAdapter.ts where thread/realtime/started events were reading payload.sessionId instead of payload.realtimeSessionId.
  • Adds 'Amazon Bedrock' label support in CodexProvider.ts for amazonBedrock account types, returning undefined for other unrecognized types.
  • Replaces scattered V2ThreadStartParams__ServiceTier / V2TurnStartParams__ServiceTier type references in CodexSessionRuntime.ts with a single CodexServiceTier alias derived from NonNullable<V2ThreadStartParams["serviceTier"]>.
  • Risk: The upstream schema churn removes and restructures several existing types (e.g. SandboxPolicy, GhostCommit, V2ThreadTurnsList*), which may break callers not covered by the updated tests.

Macroscope summarized 9c6dc73.

- Regenerate app-server protocol types from the latest upstream ref
- Map realtime start notifications to upstream session IDs
- Add Bedrock auth labeling and broaden Codex service tier typing
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ed860409-7a1c-4ec7-b562-c6e3da3474b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/ffd5eff9

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels May 8, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 8, 2026

Approvability

Verdict: Needs human review

Diff is too large for automated approval analysis. A human reviewer should evaluate this PR.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit dd32f52 into main May 8, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the t3code/ffd5eff9 branch May 8, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL 1,000+ changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant