Refresh Codex protocol bindings and adapter mappings#2590
Merged
juliusmarminge merged 1 commit intomainfrom May 8, 2026
Merged
Refresh Codex protocol bindings and adapter mappings#2590juliusmarminge merged 1 commit intomainfrom
juliusmarminge merged 1 commit intomainfrom
Conversation
- Regenerate app-server protocol types from the latest upstream ref - Map realtime start notifications to upstream session IDs - Add Bedrock auth labeling and broaden Codex service tier typing
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
ApprovabilityVerdict: Needs human review Diff is too large for automated approval analysis. A human reviewer should evaluate this PR. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
realtimeSessionIdfield.serviceTierschema and added auth labeling for Amazon Bedrock accounts.Testing
bun fmtbun lintbun typecheckbun run testNote
Medium Risk
Regenerates and expands Codex protocol bindings to a new upstream ref, which can subtly change request/notification shapes consumed across the server. Also tweaks adapter/provider mapping logic (realtime session id + auth labeling), so regressions would show up as missing/incorrect runtime events or status display.
Overview
Refreshes the generated
effect-codex-app-serverprotocol bindings to a newer upstream ref, adding/removing various request/response/notification method constants and schema exports to match the updated Codex app-server protocol.Fixes Codex realtime start event mapping to use the upstream
realtimeSessionIdfield (instead ofsessionId) and adds test coverage for this mapping.Extends Codex provider status reporting to label
amazonBedrockaccounts as Amazon Bedrock, with a new registry test to verify the auth label/type, and updates runtime option typing to alignserviceTierwith the latest shared schema.Reviewed by Cursor Bugbot for commit 9c6dc73. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Refresh Codex protocol bindings and fix
realtimeSessionIdmapping in adaptereffect-codex-app-serverto a new upstream protocol reference (07b6951), adding methods likethread/approveGuardianDeniedAction,hooks/list,marketplace/upgrade, and several plugin/process/remoteControl notifications, while removingdevice/key/*andthread/turns/list.CodexAdapter.tswherethread/realtime/startedevents were readingpayload.sessionIdinstead ofpayload.realtimeSessionId.'Amazon Bedrock'label support inCodexProvider.tsforamazonBedrockaccount types, returningundefinedfor other unrecognized types.V2ThreadStartParams__ServiceTier/V2TurnStartParams__ServiceTiertype references inCodexSessionRuntime.tswith a singleCodexServiceTieralias derived fromNonNullable<V2ThreadStartParams["serviceTier"]>.SandboxPolicy,GhostCommit,V2ThreadTurnsList*), which may break callers not covered by the updated tests.Macroscope summarized 9c6dc73.