Skip to content

Constrain provider update popover overflow#2669

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/158743d5
May 13, 2026
Merged

Constrain provider update popover overflow#2669
juliusmarminge merged 1 commit into
mainfrom
t3code/158743d5

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 13, 2026

Summary

  • Constrain the provider update popover to the viewport so long update commands do not overflow off-screen.
  • Wrap the update command in a horizontal scroll area inside the popover to preserve readability without expanding the popup width.
  • Add a browser test covering a long provider update command and verifying the popup remains fixed-width with horizontal overflow handled internally.

Testing

  • Added a browser test in SettingsPanels.browser.tsx for long update commands.
  • Not run: bun fmt
  • Not run: bun lint
  • Not run: bun typecheck
  • Not run: bun run test

Note

Low Risk
Low risk UI-only change that adjusts popover sizing/overflow for provider update commands and adds a browser regression test; no auth, data, or backend behavior changes.

Overview
Constrains the provider update popover width to the viewport (replacing a fixed width) so it can’t overflow off-screen.

Wraps the provider updateCommand display in a horizontal ScrollArea to keep long commands readable without expanding the popover, and adds a browser test in SettingsPanels.browser.tsx that asserts long commands remain within the fixed-width popup while enabling horizontal overflow.

Reviewed by Cursor Bugbot for commit 486f4b1. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Constrain provider update popover width and make long update commands horizontally scrollable

  • Fixes the update-advisory popover in ProviderInstanceCard.tsx to use a responsive fixed width (min(21rem, 100vw - 1.5rem)) so it no longer overflows the viewport.
  • Wraps the update command code snippet in a ScrollArea so long commands scroll horizontally within the constrained popover instead of breaking layout.
  • Adds a browser test in SettingsPanels.browser.tsx that verifies the popover stays within bounds and the command is scrollable when given a very long updateCommand.

Macroscope summarized 486f4b1.

- Keep long update commands scrollable inside the fixed popover
- Add browser coverage for oversized provider update commands
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d9e1ff9f-e325-4806-9e0c-df1717d8d5b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/158743d5

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 13, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 13, 2026

Approvability

Verdict: Approved

This is a self-contained UI fix that constrains overflow in a popover by using responsive CSS widths and a ScrollArea component. The change is accompanied by a test and has no runtime behavior impact beyond visual presentation.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 7e20b23 into main May 13, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the t3code/158743d5 branch May 13, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant