Constrain provider update popover overflow#2669
Conversation
- Keep long update commands scrollable inside the fixed popover - Add browser coverage for oversized provider update commands
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This is a self-contained UI fix that constrains overflow in a popover by using responsive CSS widths and a ScrollArea component. The change is accompanied by a test and has no runtime behavior impact beyond visual presentation. You can customize Macroscope's approvability policy. Learn more. |
Summary
Testing
SettingsPanels.browser.tsxfor long update commands.bun fmtbun lintbun typecheckbun run testNote
Low Risk
Low risk UI-only change that adjusts popover sizing/overflow for provider update commands and adds a browser regression test; no auth, data, or backend behavior changes.
Overview
Constrains the provider update popover width to the viewport (replacing a fixed width) so it can’t overflow off-screen.
Wraps the provider
updateCommanddisplay in a horizontalScrollAreato keep long commands readable without expanding the popover, and adds a browser test inSettingsPanels.browser.tsxthat asserts long commands remain within the fixed-width popup while enabling horizontal overflow.Reviewed by Cursor Bugbot for commit 486f4b1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Constrain provider update popover width and make long update commands horizontally scrollable
min(21rem, 100vw - 1.5rem)) so it no longer overflows the viewport.ScrollAreaso long commands scroll horizontally within the constrained popover instead of breaking layout.updateCommand.Macroscope summarized 486f4b1.