Exclude workspace packages from desktop runtime deps#2688
Conversation
- Skip bundled workspace packages when staging desktop dependencies - Add a regression test for the runtime dependency filter
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Build script change that filters out workspace packages from desktop runtime dependencies, preventing redundant bundling. Well-tested with clear scope and no production runtime impact. You can customize Macroscope's approvability policy. Learn more. |
* Simplify workspace package builds and deps (pingdotgg#2676) * Skip healthy env reconnects after browser resume (pingdotgg#2677) * feat(marketing): Made marketing site less cringe (pingdotgg#2681) * Back off VCS remote refresh failures (pingdotgg#2686) * [codex] add diagnostics resource history (pingdotgg#2685) Co-authored-by: Julius Marminge <julius@macmini.local> * Exclude workspace packages from desktop runtime deps (pingdotgg#2688) * docs(upstream): record first upstream sync --------- Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Julius Marminge <julius@macmini.local>
Summary
workspace:dependencies from the staged desktop runtime dependency set.electronexcluded while still resolving catalog-backed runtime dependencies for the desktop artifact.Testing
resolveDesktopRuntimeDependenciesto verify workspace packages are omitted.Note
Medium Risk
Changes dependency selection for the desktop staging
package.json, which could affect runtime packaging if any needed modules were previously referenced viaworkspace:. Scope is small and covered by a new regression unit test.Overview
Ensures the staged desktop
package.jsonruntime dependency set excludes bothelectronand any dependencies declared withworkspace:specs, while still resolving catalog-backed versions viaresolveCatalogDependencies.Exports
resolveDesktopRuntimeDependenciesand adds a unit test asserting workspace packages are omitted from the staged dependency map.Reviewed by Cursor Bugbot for commit 09e17a4. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Exclude workspace packages from desktop runtime dependencies
Updates
resolveDesktopRuntimeDependenciesin build-desktop-artifact.ts to filter out any dependency whose spec starts withworkspace:, in addition to the existingelectronexclusion. Exports the function and adds a test verifying the filtering behavior.Macroscope summarized 09e17a4.