Skip to content

Exclude workspace packages from desktop runtime deps#2688

Merged
juliusmarminge merged 1 commit into
mainfrom
feature/exclude-workspace-desktop-deps
May 14, 2026
Merged

Exclude workspace packages from desktop runtime deps#2688
juliusmarminge merged 1 commit into
mainfrom
feature/exclude-workspace-desktop-deps

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 14, 2026

Summary

  • Exclude workspace: dependencies from the staged desktop runtime dependency set.
  • Keep electron excluded while still resolving catalog-backed runtime dependencies for the desktop artifact.
  • Add a regression test covering workspace packages bundled into the desktop package manifest.

Testing

  • Not run (PR content only).
  • Added a unit test for resolveDesktopRuntimeDependencies to verify workspace packages are omitted.

Note

Medium Risk
Changes dependency selection for the desktop staging package.json, which could affect runtime packaging if any needed modules were previously referenced via workspace:. Scope is small and covered by a new regression unit test.

Overview
Ensures the staged desktop package.json runtime dependency set excludes both electron and any dependencies declared with workspace: specs, while still resolving catalog-backed versions via resolveCatalogDependencies.

Exports resolveDesktopRuntimeDependencies and adds a unit test asserting workspace packages are omitted from the staged dependency map.

Reviewed by Cursor Bugbot for commit 09e17a4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Exclude workspace packages from desktop runtime dependencies

Updates resolveDesktopRuntimeDependencies in build-desktop-artifact.ts to filter out any dependency whose spec starts with workspace:, in addition to the existing electron exclusion. Exports the function and adds a test verifying the filtering behavior.

Macroscope summarized 09e17a4.

- Skip bundled workspace packages when staging desktop dependencies
- Add a regression test for the runtime dependency filter
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a2226583-377d-4cb8-a3a0-d7fec0baa282

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/exclude-workspace-desktop-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

@juliusmarminge juliusmarminge enabled auto-merge (squash) May 14, 2026 07:29
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels May 14, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 14, 2026

Approvability

Verdict: Approved

Build script change that filters out workspace packages from desktop runtime dependencies, preventing redundant bundling. Well-tested with clear scope and no production runtime impact.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit ea20e80 into main May 14, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/exclude-workspace-desktop-deps branch May 14, 2026 07:32
Donkijote added a commit to Donkijote/dk-ide that referenced this pull request May 14, 2026
* Simplify workspace package builds and deps (pingdotgg#2676)

* Skip healthy env reconnects after browser resume (pingdotgg#2677)

* feat(marketing): Made marketing site less cringe (pingdotgg#2681)

* Back off VCS remote refresh failures (pingdotgg#2686)

* [codex] add diagnostics resource history (pingdotgg#2685)

Co-authored-by: Julius Marminge <julius@macmini.local>

* Exclude workspace packages from desktop runtime deps (pingdotgg#2688)

* docs(upstream): record first upstream sync

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Julius Marminge <julius@macmini.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant