Make SSH readiness handling more idiomatic Effect#2716
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Data.TaggedErrorto serializableSchema.TaggedErrorClassdefinitions.Duration.Inputvalues and track optional last-failure state withOption.Schema.isguards.Why
This keeps the SSH Effect code closer to the rest of the codebase's idioms: schema-backed errors are serializable and structured, timing policies flow through
Durationand Effect timeout/retry primitives, and optional diagnostic state avoidsnullsentinels.UI Changes
None.
Checklist
Note
Refactor SSH error classes to
Schema.TaggedErrorClasswith granular readiness error variantspackages/ssh/src/errors.tsfromData.TaggedErrortoSchema.TaggedErrorClass, enabling schema-based type guards (Schema.is) in place ofinstanceofchecks.SshReadinessErrorclass into three distinct variants:SshReadinessProbeFailedError,SshReadinessProbeTimedOutError, andSshReadinessTimedOutError, each carrying specific timing and URL metadata.waitForHttpReadyinpackages/ssh/src/tunnel.tsto acceptDuration.Inputfields instead of numeric milliseconds, and emits the new specific error variants.tunnel.tswithDurationvalues; computed millisecond values are equivalent.instanceofchecks against the old SSH error classes will no longer match; callers must migrate to the schema-basedSchema.isguards or the exportedisSshReadinessErrorpredicate.Macroscope summarized 1c5a80e.