Ensure Electron runtime is installed in release workflow#2861
Conversation
- Reinstall Electron during release if the runtime is missing - Verify the desktop Electron package can be required before packaging
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This is a minor CI/CD workflow fix that adds a defensive check to ensure Electron is installed before the release build proceeds. The change only affects the build process and has no impact on production runtime behavior. You can customize Macroscope's approvability policy. Learn more. |
Summary
apps/desktop/node_modules/electronruntime is missing or incomplete.Testing
Note
Low Risk
Workflow-only change that adds a defensive install check; no application runtime or security logic is modified.
Overview
Adds an Ensure Electron runtime is installed step to the release workflow’s preflight job, immediately after
bun install --frozen-lockfile.The step mirrors the existing CI workflow: it tries to
requirethe desktop Electron package, and if that fails it clears a partialdist/path.txt, runs Electron’sinstall.js, then requires the package again so preflight fails early when the binary is missing.This reduces release failures from an incomplete Electron download after install, before version resolution, lint, typecheck, and test run.
Reviewed by Cursor Bugbot for commit 76e2159. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Ensure Electron runtime is installed before building in the release workflow
Adds a step in release.yml that verifies the Electron runtime is loadable after dependencies are installed. If the module cannot be required, it removes the
distandpath.txtartifacts and re-runsinstall.jsviabun, then confirms the module loads before proceeding.Macroscope summarized 76e2159.