Skip to content

Ensure Electron runtime is installed in release workflow#2861

Merged
juliusmarminge merged 1 commit into
mainfrom
feature/release-electron-runtime
May 29, 2026
Merged

Ensure Electron runtime is installed in release workflow#2861
juliusmarminge merged 1 commit into
mainfrom
feature/release-electron-runtime

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented May 29, 2026

Summary

  • Adds a release-workflow step to verify the Electron runtime is present before packaging.
  • Re-runs Electron's install script when the local apps/desktop/node_modules/electron runtime is missing or incomplete.
  • Fails fast by requiring the Electron package after the check to confirm the runtime is usable.

Testing

  • Not run (workflow-only change).
  • Reviewed the release workflow diff for the new Electron runtime bootstrap step.

Note

Low Risk
Workflow-only change that adds a defensive install check; no application runtime or security logic is modified.

Overview
Adds an Ensure Electron runtime is installed step to the release workflow’s preflight job, immediately after bun install --frozen-lockfile.

The step mirrors the existing CI workflow: it tries to require the desktop Electron package, and if that fails it clears a partial dist / path.txt, runs Electron’s install.js, then requires the package again so preflight fails early when the binary is missing.

This reduces release failures from an incomplete Electron download after install, before version resolution, lint, typecheck, and test run.

Reviewed by Cursor Bugbot for commit 76e2159. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Ensure Electron runtime is installed before building in the release workflow

Adds a step in release.yml that verifies the Electron runtime is loadable after dependencies are installed. If the module cannot be required, it removes the dist and path.txt artifacts and re-runs install.js via bun, then confirms the module loads before proceeding.

Macroscope summarized 76e2159.

- Reinstall Electron during release if the runtime is missing
- Verify the desktop Electron package can be required before packaging
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f6ccaa8b-2124-4588-b58c-2f5fe6aa63bc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/release-electron-runtime

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 29, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 29, 2026

Approvability

Verdict: Approved

This is a minor CI/CD workflow fix that adds a defensive check to ensure Electron is installed before the release build proceeds. The change only affects the build process and has no impact on production runtime behavior.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit e3accd6 into main May 29, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/release-electron-runtime branch May 29, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant