Skip to content

fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia#2915

Merged
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
mwolson:fix/appimage-hicolor-icons-v2
Jun 3, 2026
Merged

fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia#2915
juliusmarminge merged 1 commit into
pingdotgg:mainfrom
mwolson:fix/appimage-hicolor-icons-v2

Conversation

@mwolson
Copy link
Copy Markdown
Contributor

@mwolson mwolson commented Jun 2, 2026

Summary

Closes #2331.

This adds standard hicolor icon sizes to Linux AppImage builds so AppImageLauncher and desktop shells can resolve the integrated T3 Code icon reliably.

Problem and Fix

Problem and Why it Happened Fix
The AppImage build only staged a single large icon.png, which some desktop icon lookups (such as Noctalia on Niri) do not resolve after AppImageLauncher integration. Generate standard hicolor PNG sizes from the selected Linux icon source and point electron-builder at the generated icon directory.
Linux release runners may not have the ImageMagick command needed to generate resized icons. Install ImageMagick in the Linux release job when neither magick nor convert is available.

Validation

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run --filter @t3tools/scripts test -- build-desktop-artifact

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes: N/A, packaging-only change
  • I included a video for animation/interaction changes: N/A

Open in Devin Review

Note

Low Risk
Packaging and CI-only changes with no runtime app logic, auth, or data handling impact.

Overview
Linux AppImage packaging now stages a full hicolor-style icon set (16–512px PNGs under icons/) instead of relying on a single icon.png, and electron-builder is pointed at that directory so launchers and AppImageLauncher can resolve the app icon reliably.

The desktop build script resizes icons with ImageMagick (magick, falling back to convert), and the Linux release workflow installs ImageMagick when neither command is present. The Windows Spectre MSVC step is only re-indented.

Reviewed by Cursor Bugbot for commit 031b210. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Include standard Linux AppImage icons by generating resized PNGs with ImageMagick

  • Adds stageLinuxIconSize to build-desktop-artifact.ts which uses magick (falling back to convert) to generate PNGs at standard Linux icon sizes [16, 22, 24, 32, 48, 64, 128, 256, 512].
  • Updates stageLinuxIcons to populate an icons/ directory with these resized images, and updates createBuildConfig to point Electron Builder at that directory instead of a single icon.png.
  • Adds an 'Install ImageMagick' step in release.yml to ensure ImageMagick is available on Linux runners before the build runs.
  • Risk: if neither magick nor convert is present and the apt install step fails, the Linux build will fail with a BuildScriptError.

Macroscope summarized 031b210.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2533a61c-c389-4b03-bae1-0ce1dd3ee387

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 2, 2026

Approvability

Verdict: Approved

Build/CI-only changes that add ImageMagick installation and icon generation for Linux AppImage packaging. No application runtime behavior is affected - this is purely about generating proper icon sizes during the desktop build process.

You can customize Macroscope's approvability policy. Learn more.

@mwolson mwolson changed the title fix(desktop): Include standard Linux AppImage icons fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia Jun 3, 2026
@juliusmarminge juliusmarminge merged commit f0116e4 into pingdotgg:main Jun 3, 2026
12 of 13 checks passed
@mwolson mwolson deleted the fix/appimage-hicolor-icons-v2 branch June 3, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: AppImage installed by AppImageLauncher lacks usable Linux desktop icon

2 participants