fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia#2915
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Build/CI-only changes that add ImageMagick installation and icon generation for Linux AppImage packaging. No application runtime behavior is affected - this is purely about generating proper icon sizes during the desktop build process. You can customize Macroscope's approvability policy. Learn more. |
Summary
Closes #2331.
This adds standard hicolor icon sizes to Linux AppImage builds so AppImageLauncher and desktop shells can resolve the integrated T3 Code icon reliably.
Problem and Fix
icon.png, which some desktop icon lookups (such as Noctalia on Niri) do not resolve after AppImageLauncher integration.magicknorconvertis available.Validation
bun fmtbun lintbun typecheckbun run --filter @t3tools/scripts test -- build-desktop-artifactChecklist
Note
Low Risk
Packaging and CI-only changes with no runtime app logic, auth, or data handling impact.
Overview
Linux AppImage packaging now stages a full hicolor-style icon set (16–512px PNGs under
icons/) instead of relying on a singleicon.png, and electron-builder is pointed at that directory so launchers and AppImageLauncher can resolve the app icon reliably.The desktop build script resizes icons with ImageMagick (
magick, falling back toconvert), and the Linux release workflow installs ImageMagick when neither command is present. The Windows Spectre MSVC step is only re-indented.Reviewed by Cursor Bugbot for commit 031b210. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Include standard Linux AppImage icons by generating resized PNGs with ImageMagick
stageLinuxIconSizeto build-desktop-artifact.ts which usesmagick(falling back toconvert) to generate PNGs at standard Linux icon sizes [16, 22, 24, 32, 48, 64, 128, 256, 512].stageLinuxIconsto populate anicons/directory with these resized images, and updatescreateBuildConfigto point Electron Builder at that directory instead of a singleicon.png.magicknorconvertis present and the apt install step fails, the Linux build will fail with aBuildScriptError.Macroscope summarized 031b210.