fix(release): install hosted web workspace closure#2949
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved This is a minor Vercel build configuration change that updates package filter syntax to include workspace dependencies during installation. The change only affects build-time behavior and doesn't modify any runtime application code. You can customize Macroscope's approvability policy. Learn more. |
|
🚀 Expo continuous deployment is ready!
|
Summary
@t3tools/web...and@t3tools/scripts...instead of a hand-written workspace package listWhy
The release failed in Vercel remote build because the install command did not include the full workspace dependency closure. Vercel installed
@t3tools/contracts,@t3tools/client-runtime,@t3tools/scripts, and@t3tools/web, but the web build also resolves@t3tools/shared;packages/shared/src/model.tsthen failed to resolve@t3tools/contractsin the remote build graph.Using the
...filters matches the working GitHub partial install shape and lets pnpm/Vite+ keep the closure current as workspace deps change.Validation
vp run --filter @t3tools/web buildvp checkvp run typecheckvp install --filter '@t3tools/scripts...' --filter '@t3tools/web...' --lockfile-only --ignore-scriptsNote
Low Risk
Single-line change to Vercel installCommand only; no runtime, auth, or application logic changes.
Overview
Fixes hosted web Vercel installs by replacing a hand-picked list of workspace packages with pnpm/Vite+
...closure filters on@t3tools/scriptsand@t3tools/web.Remote builds were failing because packages such as
@t3tools/shared(pulled in by the web app) were never installed, so nested workspace deps like@t3tools/contractscould not resolve at build time. The new install shape matches the release workflow partial install and stays correct as workspace dependencies change.Reviewed by Cursor Bugbot for commit 0301f2e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix Vercel install command to use wildcarded workspace scopes for web deployment
Updates the
installCommandin vercel.ts to replace four explicit package filters with two wildcard scopes (@t3tools/scripts...and@t3tools/web...), removing the@t3tools/contractsand@t3tools/client-runtimefilters. Behavioral Change: the Vercel deployment install step now installs a different set of workspace packages than before.Macroscope summarized 0301f2e.