Skip to content

fix(release): install hosted web workspace closure#2949

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/fix-hosted-web-deploy
Jun 4, 2026
Merged

fix(release): install hosted web workspace closure#2949
juliusmarminge merged 1 commit into
mainfrom
codex/fix-hosted-web-deploy

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

Summary

  • update hosted web Vercel install command to use pnpm/Vite+ dependency-closure filters
  • install the web app and scripts roots via @t3tools/web... and @t3tools/scripts... instead of a hand-written workspace package list

Why

The release failed in Vercel remote build because the install command did not include the full workspace dependency closure. Vercel installed @t3tools/contracts, @t3tools/client-runtime, @t3tools/scripts, and @t3tools/web, but the web build also resolves @t3tools/shared; packages/shared/src/model.ts then failed to resolve @t3tools/contracts in the remote build graph.

Using the ... filters matches the working GitHub partial install shape and lets pnpm/Vite+ keep the closure current as workspace deps change.

Validation

  • vp run --filter @t3tools/web build
  • vp check
  • vp run typecheck
  • vp install --filter '@t3tools/scripts...' --filter '@t3tools/web...' --lockfile-only --ignore-scripts

Note

Low Risk
Single-line change to Vercel installCommand only; no runtime, auth, or application logic changes.

Overview
Fixes hosted web Vercel installs by replacing a hand-picked list of workspace packages with pnpm/Vite+ ... closure filters on @t3tools/scripts and @t3tools/web.

Remote builds were failing because packages such as @t3tools/shared (pulled in by the web app) were never installed, so nested workspace deps like @t3tools/contracts could not resolve at build time. The new install shape matches the release workflow partial install and stays correct as workspace dependencies change.

Reviewed by Cursor Bugbot for commit 0301f2e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Vercel install command to use wildcarded workspace scopes for web deployment

Updates the installCommand in vercel.ts to replace four explicit package filters with two wildcard scopes (@t3tools/scripts... and @t3tools/web...), removing the @t3tools/contracts and @t3tools/client-runtime filters. Behavioral Change: the Vercel deployment install step now installs a different set of workspace packages than before.

Macroscope summarized 0301f2e.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ded56d69-bef1-431e-b0f8-be1fe6c0f873

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-hosted-web-deploy

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 4, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Jun 4, 2026

Approvability

Verdict: Approved

This is a minor Vercel build configuration change that updates package filter syntax to include workspace dependencies during installation. The change only affects build-time behavior and doesn't modify any runtime application code.

You can customize Macroscope's approvability policy. Learn more.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2949
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 8397940f3380c62d20db12807ec57f7c1a880e88
Update Permalink
DetailsBranch: pr-2949
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 8397940f3380c62d20db12807ec57f7c1a880e88
Update QR

@juliusmarminge juliusmarminge enabled auto-merge (squash) June 4, 2026 17:29
@juliusmarminge juliusmarminge merged commit 9fc485a into main Jun 4, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/fix-hosted-web-deploy branch June 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant