Skip to content

[codex] fix release finalize install#2961

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-finalize-install
Jun 4, 2026
Merged

[codex] fix release finalize install#2961
juliusmarminge merged 1 commit into
mainfrom
codex/fix-release-finalize-install

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Jun 4, 2026

What changed

  • Added the @t3tools/oxlint-plugin-t3code... workspace closure to the finalize release job's setup-vp install filters.

Why

The stable release failed in the final version-bump commit step because the pre-commit hook runs vp check --fix, which loads the repo-wide local oxlint JS plugin. That finalize job only installed @t3tools/scripts..., so the plugin's effect dependency was missing and oxlint failed before linting started.

Validation

  • vp check
  • vp run typecheck
  • Local commit hook ran vp check --fix successfully while committing this workflow change

Note

Add @t3tools/oxlint-plugin-t3code to release workflow install filter

Updates the run-install args in the 'Setup Vite+' step of release.yml to include @t3tools/oxlint-plugin-t3code as a filtered package, fixing the release finalize install step.

Macroscope summarized 4bf6073.


Note

Low Risk
Single-line workflow install filter change with no runtime or application logic impact.

Overview
The Finalize release job’s setup-vp install step now includes --filter=@t3tools/oxlint-plugin-t3code... alongside @t3tools/scripts....

That job commits version bumps on main, and staged commits run vp check --fix, which loads the repo’s local oxlint plugin. Without installing that workspace package (and its deps such as effect), oxlint failed before the stable release could finish.

Reviewed by Cursor Bugbot for commit 4bf6073. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b4dfc27e-9cc5-4dbc-bb2e-88f0ced53cf0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-finalize-install

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Jun 4, 2026
@juliusmarminge juliusmarminge marked this pull request as ready for review June 4, 2026 21:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

🚀 Expo continuous deployment is ready!

  • Project → t3-code
  • Platforms → android, ios
  • Scheme → t3code-preview
  🤖 Android 🍎 iOS
Fingerprint 251694208975e82c56bd5289d014d27db782d79c 88f9ec34318a3522ac20299028ec60ca0080a665
Build Details Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Build Permalink
DetailsDistribution: INTERNAL
Build profile: preview:dev
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
App version: 0.1.0
Git commit: fff460b4abc01f29f5b2cdb5bf25d955066816ee
Update Details Update Permalink
DetailsBranch: pr-2961
Runtime version: 251694208975e82c56bd5289d014d27db782d79c
Git commit: 444121e38ba9fe6edbb15a67ece88c5602131a1c
Update Permalink
DetailsBranch: pr-2961
Runtime version: 88f9ec34318a3522ac20299028ec60ca0080a665
Git commit: 444121e38ba9fe6edbb15a67ece88c5602131a1c
Update QR

@juliusmarminge juliusmarminge enabled auto-merge (squash) June 4, 2026 21:57
@juliusmarminge juliusmarminge merged commit dfdb5a4 into main Jun 4, 2026
21 checks passed
@juliusmarminge juliusmarminge deleted the codex/fix-release-finalize-install branch June 4, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant