[codex] fix release finalize install#2961
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
🚀 Expo continuous deployment is ready!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@t3tools/oxlint-plugin-t3code...workspace closure to thefinalizerelease job'ssetup-vpinstall filters.Why
The stable release failed in the final version-bump commit step because the pre-commit hook runs
vp check --fix, which loads the repo-wide local oxlint JS plugin. That finalize job only installed@t3tools/scripts..., so the plugin'seffectdependency was missing and oxlint failed before linting started.Validation
vp checkvp run typecheckvp check --fixsuccessfully while committing this workflow changeNote
Add
@t3tools/oxlint-plugin-t3codeto release workflow install filterUpdates the
run-installargs in the 'Setup Vite+' step of release.yml to include@t3tools/oxlint-plugin-t3codeas a filtered package, fixing the release finalize install step.Macroscope summarized 4bf6073.
Note
Low Risk
Single-line workflow install filter change with no runtime or application logic impact.
Overview
The Finalize release job’s
setup-vpinstall step now includes--filter=@t3tools/oxlint-plugin-t3code...alongside@t3tools/scripts....That job commits version bumps on
main, and staged commits runvp check --fix, which loads the repo’s local oxlint plugin. Without installing that workspace package (and its deps such aseffect), oxlint failed before the stable release could finish.Reviewed by Cursor Bugbot for commit 4bf6073. Bugbot is set up for automated code reviews on this repo. Configure here.